Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zsh completion for 'docker plugin' commands #24273

Merged
merged 1 commit into from Jul 4, 2016

Conversation

sdurrheimer
Copy link
Contributor

@sdurrheimer sdurrheimer commented Jul 2, 2016

Ref. #23446

@vincentbernat
ping @albers for bash completion

Signed-off-by: Steve Durrheimer s.durrheimer@gmail.com

@vincentbernat
Copy link
Contributor

LGTM

@albers
Copy link
Member

albers commented Jul 3, 2016

can you please add a ref to the implementing PR?

@sdurrheimer
Copy link
Contributor Author

@albers done

@albers
Copy link
Member

albers commented Jul 3, 2016

Thanks @sdurrheimer

@sdurrheimer sdurrheimer force-pushed the zsh-completion-plugin branch 2 times, most recently from 618c224 to 7ae3caa Compare July 3, 2016 21:44
Signed-off-by: Steve Durrheimer <s.durrheimer@gmail.com>
@runcom
Copy link
Member

runcom commented Jul 4, 2016

LGTM

@runcom runcom merged commit 687c15f into moby:master Jul 4, 2016
@sdurrheimer sdurrheimer deleted the zsh-completion-plugin branch July 4, 2016 13:16
@thaJeztah
Copy link
Member

hm, how should we deal with these completions, since they're only available in the experimental builds? I think for bash we decided to not implement them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants