Implement `docker update` for changing container log-opts #30055

Open
vkakhnych opened this Issue Jan 11, 2017 · 3 comments

Projects

None yet

3 participants

@vkakhnych

Hello,

It's could be great to have possibility to change running container log-opts like max-size and max-file.
I have running containers that I can't recreate and that containers produce gigabytes of logs. logrotate with copytruncate doesn't works right.

Thanks!

@cpuguy83
Contributor

Hmm... I think the only safe way to do this would be to restart the process.
As such I would be -1 on adding support for this.

@thaJeztah
Member

Looks like this will be problematic yes, so -1.

I have running containers that I can't recreate and that containers produce gigabytes of logs. logrotate with copytruncate doesn't works right.

Is there a reason you cannot recreate? Overall, containers should be considered "ephemeral". Note that you can docker commit a container to an image, and start a new container from that image

@vkakhnych

In my situation these containers created by the eris blockchain project, not directly by docker. I'm not sure that all current data will be saved if remove containers by eris binary and create it again.

Of course this feature shouldn't be implemented if there is some risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment