PublishAllPorts behavior seems to have changed in remote API 1.14

[ivey]

With docker 1.11, a POST to /containers/$id/start with {"PublishAllPorts": true} would start the container and bind exposed ports as expected.

After upgrading to 1.12, the container no longer binds any ports.

API docs show no changes in this area - did something change, or is this a regression?

[thomassuckow]

I am also having trouble with the PortBindings option not exposing any ports.

[docwhat]

This is also probably the cause of jenkinsci/docker-plugin#90

[mastef]

Same problem in Shipyard

[crosbymichael]

ping @tiborvass Do you mind looking into this tomorrow if it is a regression?

[tiborvass]

@crosbymichael of course. Thanks!

[jessfraz]

I can recreate, looking into it

[jessfraz]

@ivey @docwhat @thomassuckow

CORRECTION: I cannot reproduce, sorry for the confusion.

I tested with v1.11, v1.12, v1.13, and v1.14 of the API.
I tested with a Dockerfile that exposed a port and an API request to /container/create that passed ExposedPorts , then started the container with PublishAllPorts. It worked on all versions.

Then tested building and creating/starting an image on docker version 1.1.2, and upgrading docker tp 1.2.0 and running start via the api, and cannot reproduce that way either.

Can you give some insight into the requests you are passing to the API for build, create, start, etc. Thanks!

[tiborvass]

@LK4D4 @erikh @unclejack if any of you can reproduce this please let us know!

[thomassuckow]

In the jenkins plugin case, it appears to be using PortSpecs instead of ExposedPorts. The docker API is not well documented IMO, so I am not completely sure if those options are trying to accomplish the same thing.

[thomassuckow]

I am seeing behaviour where:

POST /containers/.../start

With any of the following

{"PortBindings":{"6900/tcp":[{}]}}
{"PortBindings":{"6900/tcp":[{"HostIp":"0.0.0.0"}]}}
{"PublishAllPorts":true}

Results in:

..., "Ports":{"6900/tcp":null}}, ...

[tiborvass]

@thomassuckow can you please paste the output of docker version and docker info ?

[thomassuckow]

$ docker -H ... version
Client version: 1.1.2
Client API version: 1.13
Go version (client): go1.2.2
Git commit (client): d84a070/1.1.2
Server version: 1.2.0
Server API version: 1.14
Go version (server): go1.3.1
Git commit (server): fa7b24f

$ docker -H ... info
Containers: 51
Images: 155
Storage Driver: btrfs
Execution Driver: native-0.2
Kernel Version: 3.15.8+

I am still trying to track down the issue. I am working to recreate the (mostly) exact request as the docker client sends it (which works).

Docker client sends (works):

POST /v1.13/containers/.../start HTTP/1.1
Host: ...
User-Agent: Docker-Client/1.1.2
Content-Length: 239
Content-Type: application/json
Accept-Encoding: gzip

{"Binds":null,"ContainerIDFile":"","LxcConf":[],"Privileged":false,"PortBindings":{"6900/tcp":[{"HostIp":"0.0.0.0","HostPort":""}]},"Links":null,"PublishAllPorts":false,"Dns":null,"DnsSearch":null,"VolumesFrom":null,"NetworkMode":"bridge"}

My modified jDocker library sends (does not work):

POST /containers/.../start HTTP/1.1
Content-Type: application/json
User-Agent: Jersey/2.5.1 (HttpUrlConnection 1.6.0_32)
Host: ...
Accept: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2
Connection: keep-alive
Transfer-Encoding: chunked

d1
{"Binds":null,"ContainerIDFile":"","LxcConf":[],"PortBindings":{"6900/tcp":[{"HostIp":"0.0.0.0","HostPort":""}]},"Privileged":false,"PublishAllPorts":false,"Dns":null,"VolumesFrom":null,"NetworkMode":"bridge"}
0

[thomassuckow]

The issue is Transfer-Encoding: chunked. Something is not handling that correctly for the start command and thus the HostConfig provided is ignored.

[sfitts]

Confirmed that this is also causing #6231. FWIW, this is easy to reproduce using the docker-java API binding. For us this is a breaking issue so we've backed our Docker installation off to 1.1.1.

[jessfraz]

closing as half is fixed by #7927 and the other half is a duplicate of #6231