move plugins out of experimental #28226

vieux · 2016-11-10T01:52:40Z

ping @anusha-ragunathan @tiborvass @thaJeztah

closes #26760

thaJeztah · 2016-11-10T01:58:22Z

Can you check integration tests as well? Tests are probably skipped if experimental is not enabled

vieux · 2016-11-10T02:00:06Z

@thaJeztah right, thanks

thaJeztah

LGTM

thaJeztah · 2016-11-10T02:02:31Z

/cc @albers @sdurrheimer because this will likely affect the completion scripts

stevvooe · 2016-11-10T03:09:34Z

This cannot be merged until #28148 is merged.

anusha-ragunathan · 2016-11-10T17:47:32Z

Please add 26760, which tracks this.

tiborvass · 2016-11-10T18:06:22Z

docs/reference/api/docker_remote_api.md

@@ -6,7 +6,7 @@ keywords: "API, Docker, rcli, REST, documentation"

 <!-- This file is maintained within the docker/docker Github
     repository at https://github.com/docker/docker/. Make all
-     pull requests against that repo. If you see this file in
+5B     pull requests against that repo. If you see this file in


anusha-ragunathan · 2016-11-10T18:14:54Z

tests that need to be updated:

docker_cli_daemon_experimental_test.go (all of them)
docker_cli_events_test.go (TestEventsPluginOps)
docker_cli_authz_plugin_v2_test.go (all of them)
docker_cli_network_unix_test.go (TestDockerPluginV2NetworkDriver)

anusha-ragunathan · 2016-11-10T18:19:54Z

daemon/daemon_experimental.go needs to remove the daemon.HasExperimental checks and merge with daemon/daemon.go. Else nothing will work.

anusha-ragunathan · 2016-11-10T18:24:49Z

docs/reference/api/docker_remote_api.md

+* `GET /plugins/(plugin name)` inspect a plugin.
+* `POST /plugins/(plugin name)/set` configure a plugin.
+* `POST /plugins/(plugin name)/enable` enable a plugin.
+* `POST /plugins/(plugin name)/disable` disable a plugin.


Add plugin create:
``POST /plugins/create?name=plugin name creates a plugin.

Also missing push

anusha-ragunathan · 2016-11-10T18:25:09Z

docs/reference/api/docker_remote_api.md

@@ -184,6 +184,14 @@ This section lists each version from latest to oldest.  Each listing includes a
 * `POST /services/create` and `POST /services/(id or name)/update` now accept the `TTY` parameter, which allocate a pseudo-TTY in container.
 * `POST /services/create` and `POST /services/(id or name)/update` now accept the `DNSConfig` parameter, which specifies DNS related configurations in resolver configuration file (resolv.conf) through `Nameservers`, `Search`, and `Options`.
 * `GET /networks/(id or name)` now includes IP and name of all peers nodes for swarm mode overlay networks.
+* `GET /plugins` list plugins.
+* `POST /plugins/pull?name=<plugin name>` install a plugin.


should be pulls a plugin. install implies an additional enable.

anusha-ragunathan · 2016-11-10T18:27:37Z

docs/extend/config.md

@@ -171,7 +170,6 @@ Config provides the base accessible fields for working with V0 plugin format

 ```
 {
-       	"configVersion": "v0",


Why is this being removed?

It's a doc left-over from a previous PR, it's already removed from the code, after talking with @tiborvass and @stevvooe.

You needed to json-decode in order to get the version, if the format change a lot, it won't even work.

The version is already present in the media-type, that's how other media handle versioning.

vieux · 2016-11-10T18:40:56Z

Thanks @anusha-ragunathan, I missed a lot indeed

anusha-ragunathan · 2016-11-10T18:44:19Z

Thank you for doing this @vieux . I know you've been burning the midnight oil with a lotta plugin PRs!

vdemeester

LGTM 🐸

anusha-ragunathan · 2016-11-10T21:15:39Z

docs/reference/api/docker_remote_api.md

+* `POST /plugins/(plugin name)/set` configure a plugin.
+* `POST /plugins/(plugin name)/enable` enable a plugin.
+* `POST /plugins/(plugin name)/disable` disable a plugin.
+* `POST /plugins/(plugin name)/push` push a pluging.


typo pluging

anusha-ragunathan · 2016-11-10T21:20:49Z

plugin/distribution/pull.go

@@ -153,7 +153,8 @@ func Pull(ref reference.Named, rs registry.Service, metaheader http.Header, auth
 		logrus.Debugf("pull.go: error in json.Unmarshal(): %v", err)
 		return nil, err
 	}
-	if m.Config.MediaType != schema2.MediaTypePluginConfig {
+	if m.Config.MediaType != schema2.MediaTypePluginConfig &&
+		m.Config.MediaType != "application/vnd.docker.plugin.image.v0+json" { //TODO: remove this v0 before 1.13 GA


A similar check for image.v0 needs to be added in https://github.com/vieux/docker/blob/exit_exp_plugin/distribution/pull_v2.go#L361, to avoid using docker pull to pull plugin images.

anusha-ragunathan · 2016-11-10T21:59:40Z

LGTM (once tests are all green)

tiborvass · 2016-11-10T23:19:27Z

@vieux needs rebase :(

tiborvass · 2016-11-10T23:20:30Z

apart from small conflict, LGTM

lowenna · 2016-11-10T23:46:44Z

As plugins don't work on Windows (at least I've never verified and don't believe they do anyway), can we get this updated to report a nice "not supported on this platform" message for the API endpoints? And document accordingly.

Signed-off-by: Victor Vieux <vieux@docker.com>

vieux · 2016-11-10T23:53:56Z

@jhowardmsft yes it's on my list of things to do during the freeze

lowenna · 2016-11-11T00:02:38Z

Thanks, @vieux

tomdee · 2016-11-16T01:20:54Z

@vieux Am I right in thinking that network plugins still aren't supported?

mavenugo · 2016-11-16T01:52:22Z

@tomdee network plugins are supported. PTAL : https://github.com/docker/docker/blob/master/integration-cli/docker_cli_network_unix_test.go#L771

vieux added priority/P1 Important: P1 issues are a top priority and a must-have for the next release. status/2-code-review labels Nov 10, 2016

vieux added this to the 1.13.0 milestone Nov 10, 2016

vieux self-assigned this Nov 10, 2016

GordonTheTurtle added the status/0-triage label Nov 10, 2016

thaJeztah removed the status/0-triage label Nov 10, 2016

vieux force-pushed the exit_exp_plugin branch from b71079e to 3f3a993 Compare November 10, 2016 02:00

thaJeztah approved these changes Nov 10, 2016

View reviewed changes

thaJeztah added impact/changelog impact/cli impact/documentation labels Nov 10, 2016

vieux force-pushed the exit_exp_plugin branch from 3f3a993 to b77508a Compare November 10, 2016 17:51

tiborvass reviewed Nov 10, 2016

View reviewed changes

anusha-ragunathan reviewed Nov 10, 2016

View reviewed changes

vieux force-pushed the exit_exp_plugin branch from b77508a to d949d07 Compare November 10, 2016 18:35

vieux force-pushed the exit_exp_plugin branch from 9f276f0 to 9375710 Compare November 10, 2016 20:08

vdemeester approved these changes Nov 10, 2016

View reviewed changes

anusha-ragunathan reviewed Nov 10, 2016

View reviewed changes

vieux force-pushed the exit_exp_plugin branch 4 times, most recently from 0bc70b9 to 683167c Compare November 10, 2016 21:56

vieux added 2 commits November 10, 2016 15:51

move plugins out of experimental

c410222

Signed-off-by: Victor Vieux <vieux@docker.com>

update media_type

970b23d

Signed-off-by: Victor Vieux <vieux@docker.com>

vieux force-pushed the exit_exp_plugin branch from 683167c to 970b23d Compare November 10, 2016 23:58

vieux added status/4-merge and removed status/2-code-review labels Nov 11, 2016

vieux merged commit acd6e0d into moby:master Nov 11, 2016

vieux deleted the exit_exp_plugin branch November 11, 2016 01:30

nishanttotla mentioned this pull request Nov 11, 2016

[WIP] Re-enable plugin filter moby/swarmkit#1517

Closed

twang2218 mentioned this pull request Jan 18, 2017

Feature Request: Add option to search/filter by type and platform option docker/hub-feedback#923

Closed

thaJeztah mentioned this pull request Aug 2, 2022

api: swagger: add missing "force" query arg on plugin disable #43897

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move plugins out of experimental #28226

move plugins out of experimental #28226

vieux commented Nov 10, 2016 •

edited

thaJeztah commented Nov 10, 2016

vieux commented Nov 10, 2016

thaJeztah left a comment

thaJeztah commented Nov 10, 2016

stevvooe commented Nov 10, 2016

anusha-ragunathan commented Nov 10, 2016

tiborvass Nov 10, 2016

anusha-ragunathan commented Nov 10, 2016

anusha-ragunathan commented Nov 10, 2016

anusha-ragunathan Nov 10, 2016

anusha-ragunathan Nov 10, 2016

anusha-ragunathan Nov 10, 2016

anusha-ragunathan Nov 10, 2016

vieux Nov 10, 2016

vieux commented Nov 10, 2016

anusha-ragunathan commented Nov 10, 2016

vdemeester left a comment

anusha-ragunathan Nov 10, 2016

anusha-ragunathan Nov 10, 2016

vieux Nov 10, 2016

anusha-ragunathan commented Nov 10, 2016

tiborvass commented Nov 10, 2016

tiborvass commented Nov 10, 2016

lowenna commented Nov 10, 2016 •

edited

vieux commented Nov 10, 2016

lowenna commented Nov 11, 2016

tomdee commented Nov 16, 2016

mavenugo commented Nov 16, 2016 •

edited

move plugins out of experimental #28226

move plugins out of experimental #28226

Conversation

vieux commented Nov 10, 2016 • edited

thaJeztah commented Nov 10, 2016

vieux commented Nov 10, 2016

thaJeztah left a comment

Choose a reason for hiding this comment

thaJeztah commented Nov 10, 2016

stevvooe commented Nov 10, 2016

anusha-ragunathan commented Nov 10, 2016

Choose a reason for hiding this comment

anusha-ragunathan commented Nov 10, 2016

anusha-ragunathan commented Nov 10, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vieux commented Nov 10, 2016

anusha-ragunathan commented Nov 10, 2016

vdemeester left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anusha-ragunathan commented Nov 10, 2016

tiborvass commented Nov 10, 2016

tiborvass commented Nov 10, 2016

lowenna commented Nov 10, 2016 • edited

vieux commented Nov 10, 2016

lowenna commented Nov 11, 2016

tomdee commented Nov 16, 2016

mavenugo commented Nov 16, 2016 • edited

vieux commented Nov 10, 2016 •

edited

lowenna commented Nov 10, 2016 •

edited

mavenugo commented Nov 16, 2016 •

edited