Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Make.ps1 default to build binaries #30639

Merged
merged 1 commit into from Feb 7, 2017

Conversation

lowenna
Copy link
Member

@lowenna lowenna commented Feb 1, 2017

Signed-off-by: John Howard jhoward@microsoft.com

@johnstep Minor tweak to make.ps1 which makes local development outside of a container on Windows a tiny bit easier for the most common operation. The default for running make.ps1 is now to build the binaries rather than throw an error. Hence can just run make.ps1 rather than explicitly doing make.ps1 -Binary

Signed-off-by: John Howard <jhoward@microsoft.com>
Copy link
Member

@johnstep johnstep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 0a51ad2 into moby:master Feb 7, 2017
@GordonTheTurtle GordonTheTurtle added this to the 1.14.0 milestone Feb 7, 2017
@lowenna lowenna deleted the jjh/makeshortcut branch February 7, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants