Add testcase for build arg without value #31991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
add-build-arg-testcase
branch
from
9a9d028
to
1b3eb52
Compare
GordonTheTurtle
added
the
dco/no
|
Nice. Though I do wonder if there's a bit of a bigger issue here around what happens to a client when the daemon it's targeting panics. Especially since the client clearly could not continue in a healthy manner but still returned 0 like there was no error. |
tonistiigi
force-pushed
the
add-build-arg-testcase
branch
from
1b3eb52
to
8f37715
Compare
GordonTheTurtle
removed
the
dco/no
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #31990
Issue itself fixed by #31351
@nathanleclaire
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com