Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the alias to the service name instead of the network name #32128

Merged
merged 1 commit into from Mar 28, 2017

Conversation

vdemeester
Copy link
Member

This makes it work a little closer to compose part and it is more
correct 馃懠

Fixes #30836

/cc @thaJeztah @dnephin @mavenugo @icecrime @cpuguy83 @AkihiroSuda

馃

Signed-off-by: Vincent Demeester vincent@sbr.pm

This makes it work a little closer to compose part and it is more
correct 馃懠

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester
Copy link
Member Author

z failures is unrelated 馃懠

@vdemeester vdemeester merged commit 4155343 into moby:master Mar 28, 2017
@vdemeester vdemeester deleted the 30836-set-alias-to-servicename branch March 28, 2017 07:46
@vieux vieux mentioned this pull request Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker deploy from bundle file not setting alias as service name
5 participants