Skip to content

Conversation

@WayneYe
Copy link

@WayneYe WayneYe commented Oct 21, 2022

Proposed changes

This restart policy section in docker-compose document was out of date and really miss leading (for example docker/compose#8756 (comment))

Updated this to be consistent with: https://docs.docker.com/engine/reference/run/#restart-policies---restart

Related issues (optional)

docker/compose#8756 (comment)

This restart policy section in docker-compose document was out of date and really miss leading (for example docker/compose#8756 (comment))

Updated this to be consistent with: https://docs.docker.com/engine/reference/run/#restart-policies---restart
@netlify
Copy link

netlify bot commented Oct 21, 2022

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 7051c3c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6352ee93fee7f900084c50a2
😎 Deploy Preview https://deploy-preview-15936--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aevesdocker aevesdocker added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Oct 21, 2022
@usha-mandya
Copy link
Member

@glours Could you PTAL?

@WayneYe
Copy link
Author

WayneYe commented Oct 24, 2022

@glours Could you PTAL?

@glours Could you PTAL?

@glours
Copy link
Contributor

glours commented Oct 24, 2022

@usha-mandya @WayneYe The issue should not be fixed on the documentation side but directly in Compose. I did a PR to address that. IHMO we can close this PR

@usha-mandya
Copy link
Member

Thanks @glours. Closing this PR.

@WayneYe
Copy link
Author

WayneYe commented Oct 24, 2022

@usha-mandya @WayneYe The issue should not be fixed on the documentation side but directly in Compose. I did a PR to address that. IHMO we can close this PR

Thanks! Hope your PR got merged/released soon, and the official documentation gets updated.

@WayneYe WayneYe deleted the patch-1 branch October 24, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compose Relates to docker-compose.yml spec or docker-compose binary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants