Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Oct 11, 2024

  • Restructured the content from a single section into multiple pages.
  • Removed callouts about extensions being in limited public beta. (Docker extension still EA.)
  • Misc editorial improvements.

@dvdksn dvdksn requested review from Benehiko and krissetto October 11, 2024 13:33
@github-actions github-actions bot added the hugo Updates related to hugo label Oct 11, 2024
@netlify
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 8029815
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/672cad5aab4df90008cf7688
😎 Deploy Preview https://deploy-preview-21107--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn force-pushed the copilot-restructure branch 2 times, most recently from d7078b7 to 49d8897 Compare October 11, 2024 13:36
@github-actions github-actions bot added the area/release Relates to CI or deployment label Oct 11, 2024
@dvdksn dvdksn force-pushed the copilot-restructure branch from d988efd to cff9e4d Compare October 14, 2024 08:27
Comment on lines 24 to 37
### Ask questions about your project

You can ask questions about your project, such as:

- `@docker what is the best way to Dockerize this project`
- `@docker can you help me find vulnerabilities in my project?`

The Docker agent will analyze your project, generate the necessary files, and,
if applicable, offer to raise a pull request with the necessary Docker assets.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole section is untrue atm. The agent does not scan the user's repository for anything outside of the containerization and scout features, so it can't really answer generic questions related to the project as a whole, or go look at a specific file that's not currently open in the user's editor (and possibly github.com).

What it can see, if the user grants it the permissions to do so, is the currently active file and eventual highlighted parts of that file.
Asking questions related to the currently open file does work quite well

## Setup

Before you can start interacting with the Docker agent, make sure you've
[installed](./install.md) the extension for your organization.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should say user rather than organization here, then provide a separate section or note on organizations

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this img can be updated soon as the new ux will go online

Copy link

@krissetto krissetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for now as to not block this pr and to facilitate iteration

@dvdksn dvdksn force-pushed the copilot-restructure branch 2 times, most recently from 630fe53 to 6bfb20e Compare November 6, 2024 15:53
@dvdksn dvdksn requested a review from a team November 6, 2024 15:54
@dvdksn
Copy link
Contributor Author

dvdksn commented Nov 6, 2024

thanks @krissetto - I did push an update to fix some more of your comments. We can continue to iterate in followups and as the extension evolves

Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two picky nits, rest looks great

dvdksn added 10 commits November 7, 2024 13:06
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the copilot-restructure branch from 6bfb20e to 8029815 Compare November 7, 2024 12:06
@dvdksn dvdksn requested a review from aevesdocker November 7, 2024 12:06
@dvdksn dvdksn merged commit 4349b25 into docker:main Nov 7, 2024
14 checks passed
@dvdksn dvdksn deleted the copilot-restructure branch November 7, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/copilot area/release Relates to CI or deployment hugo Updates related to hugo status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants