Skip to content

Conversation

@sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Oct 24, 2024

Description

What's changing?

  • Provided more context for each guide
  • Updated steps/sections in guide that either used incorrect formatting or needed updated/fixed
  • Moved Docker Hub/Admin Console tabs to make Admin Console first (since we want to move people to Admin Console)
  • Fixed broken links across shortcode files

Related issues or tickets

ENGDOCS-2269

Reviews

@docker/iam-team

  • Technical review
  • Editorial review

@netlify
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 8a29833
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/671fbc39131b0400080812f2
😎 Deploy Preview https://deploy-preview-21239--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/security hugo Updates related to hugo labels Oct 24, 2024
@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review October 25, 2024 17:12
@sarahsanders-docker sarahsanders-docker changed the title DRAFT: Update JIT, SCIM, and group mapping guides Update JIT, SCIM, and group mapping guides Oct 25, 2024
@sarahsanders-docker sarahsanders-docker requested review from a team and removed request for aevesdocker October 25, 2024 17:12
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Much clearer. Just two nits, rest LGTM!

Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace police 🚓

sarahsanders-docker and others added 4 commits October 28, 2024 09:21
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Copy link
Contributor

@ivan-californias ivan-californias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sarahsanders-docker sarahsanders-docker merged commit a691e88 into docker:main Oct 28, 2024
13 of 14 checks passed
@sarahsanders-docker sarahsanders-docker deleted the ENGDOCS-2269 branch December 18, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants