guides: rework filter logic, presentation #21244
Merged
+329
−318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
force-pushed
the
guides-filters-tags
branch
from
4b3c6b6 to
ed94958
Compare
dvdksn
force-pushed
the
guides-filters-tags
branch
from
ed94958 to
6fc52d1
Compare
- Rework the filtering system for guides to drop the use of the "products", "subjects", and "levels" taxonomies in favor of "tags" and "languages" - This change means that the existing taxonomy functionality integrates better with the guides filtering, and there are fewer parameters to keep in mind when adding metadata to a guide - Only two taxonomies instead of three - Only one of those taxonomies are guides-specific (languages) - The other taxonomy (tags) works for all content - Updates how tags and tag pages are rendered in general Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
guides-filters-tags
branch
from
6fc52d1 to
56e58ae
Compare
sarahsanders-docker
approved these changes
Oct 29, 2024
Contributor
sarahsanders-docker
left a comment
sarahsanders-docker
left a comment
There was a problem hiding this comment.
I really like the icons for the language guides. The only nit I have is that "Product demo" might not feel like intuitive naming for me as a user if I go to the Guides page looking for a product-specific guide. I might end up using CTRL + F to find Docker Build Cloud specific guides for example which defeats the purpose of the filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANDfor cross-taxonomy filtersORwithin the same taxonomy (e.g. you select "python" and "javascript", guides matching both python and javascript will displayPreview: https://deploy-preview-21244--docsdocker.netlify.app/guides/