-
Notifications
You must be signed in to change notification settings - Fork 8.1k
guides: add docker+zscaler guide #21284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bccd8a7 to
52cb030
Compare
|
Looks good to me. |
karman-docker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| If you are not using Zscaler as a system-level proxy, manually configure proxy | ||
| settings in Docker Desktop. Set up proxy settings for all clients in the | ||
| organization using [Settings Management](/manuals/security/for-admins/hardened-desktop/settings-management/_index.md), | ||
| or edit proxy configuration in the Docker Desktop GUI under [**Settings > Resources > Proxies**](/manuals/desktop/settings.md#proxies). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvdksn I don't see anything explicit in our Contribute guides and UI steps across the docs seem to be inconsistent, is there a preferred way (step > step > step or ordered list) to write UI interaction steps? or is it case by case? just want to understand better for context!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I don't have an answer! I just went with what I think would be useful. Curious to hear other's thoughts as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that menu cascades (step > step > step) look super clean. I remember someone mentioned that it's not accessibility friendly, like screen readers might read it weird.
Microsoft's style guide endorses it though.
sarahsanders-docker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit on e.g. and just left a comment about something I am curious about/wanted your insight on as I continue learning our style guide
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
52cb030 to
e9cc831
Compare
Description
This PR adds a Docker+Zscaler guide, with instructions on how to avoid common
errors that might occur when you run containers or build images in a
Zscaler-proxied environment.
I chose not to include the use case of mounting certs into a running container.
Instead, I wanted to focus on the preferred use case, which is to build images
with the certificates baked in. I did attempt to highlight why.
Related issues or tickets