Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Oct 30, 2024

Description

This PR adds a Docker+Zscaler guide, with instructions on how to avoid common
errors that might occur when you run containers or build images in a
Zscaler-proxied environment.

I chose not to include the use case of mounting certs into a running container.
Instead, I wanted to focus on the preferred use case, which is to build images
with the certificates baked in. I did attempt to highlight why.

Related issues or tickets

@netlify
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e9cc831
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/672376460451aa0008aefecd
😎 Deploy Preview https://deploy-preview-21284--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karman-docker
Copy link
Contributor

Looks good to me.

Copy link
Contributor

@karman-docker karman-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn dvdksn requested a review from a team October 30, 2024 14:25
If you are not using Zscaler as a system-level proxy, manually configure proxy
settings in Docker Desktop. Set up proxy settings for all clients in the
organization using [Settings Management](/manuals/security/for-admins/hardened-desktop/settings-management/_index.md),
or edit proxy configuration in the Docker Desktop GUI under [**Settings > Resources > Proxies**](/manuals/desktop/settings.md#proxies).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvdksn I don't see anything explicit in our Contribute guides and UI steps across the docs seem to be inconsistent, is there a preferred way (step > step > step or ordered list) to write UI interaction steps? or is it case by case? just want to understand better for context!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I don't have an answer! I just went with what I think would be useful. Curious to hear other's thoughts as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that menu cascades (step > step > step) look super clean. I remember someone mentioned that it's not accessibility friendly, like screen readers might read it weird.
Microsoft's style guide endorses it though.

Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit on e.g. and just left a comment about something I am curious about/wanted your insight on as I continue learning our style guide

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the docker-zscaler-guide branch from 52cb030 to e9cc831 Compare October 31, 2024 12:21
@dvdksn dvdksn requested review from a team and sarahsanders-docker October 31, 2024 12:21
@dvdksn dvdksn merged commit 2773210 into docker:main Nov 7, 2024
14 checks passed
@dvdksn dvdksn deleted the docker-zscaler-guide branch November 7, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker and zscaler - how to streamline the process/managing of certs

5 participants