Skip to content

Conversation

@aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Nov 4, 2024

Description

Tidy up of DD IA. Creates a 'setup' folder and moves relevant pages within it. First PR of a few

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/engine Issue affects Docker engine/daemon label Nov 4, 2024
@netlify
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 835eb1c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6729edfb316d9c0008292a35
😎 Deploy Preview https://deploy-preview-21329--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/compose Relates to docker-compose.yml spec or docker-compose binary area/install Relates to installing a product area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/get-started Relates to get started and onboarding docs area/guides labels Nov 4, 2024
@aevesdocker aevesdocker marked this pull request as ready for review November 4, 2024 15:19
@aevesdocker aevesdocker requested a review from dvdksn as a code owner November 4, 2024 15:19
@aevesdocker aevesdocker requested a review from a team November 4, 2024 15:19
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I just left some suggestions for linking to .md files!

Install Docker Desktop on
[Mac](/desktop/install/mac-install/),
[Windows](/desktop/install/windows-install/), or
[Mac](/desktop/setup/install/mac-install/),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this link go to the .md file? /manuals/desktop/setup/install/mac-install.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because this is a link that appears on a card, so the formatting needs to be different

@aevesdocker aevesdocker merged commit 3ea0cd7 into docker:main Nov 5, 2024
13 of 14 checks passed
dvdksn pushed a commit to dvdksn/docs that referenced this pull request Nov 7, 2024
<!--Delete sections as needed -->

## Description

Tidy up of DD IA. Creates a 'setup' folder and moves relevant pages
within it. First PR of a few

## Related issues or tickets

<!-- Related issues, pull requests, or Jira tickets -->

## Reviews

<!-- Notes for reviewers here -->
<!-- List applicable reviews (optionally @tag reviewers) -->

- [ ] Technical review
- [ ] Editorial review
- [ ] Product review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compose Relates to docker-compose.yml spec or docker-compose binary area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/engine Issue affects Docker engine/daemon area/get-started Relates to get started and onboarding docs area/guides area/install Relates to installing a product area/security status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants