ENGDOCS-2300 #21354
Merged
ENGDOCS-2300 #21354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/engine
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
requested changes
Nov 7, 2024
Contributor
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
Please update the broken link upstream before merging this
Contributor
|
We also need the upstream fix to be merged first, backported to the release branch, and then vendor the updates before we can merge this. Otherwise all CI tests will fail. |
Contributor
Author
Would you be able to assist me with this? I don't trust my Git-foo and if I mess up this PR I'll cry |
Contributor
|
@aevesdocker for sure, let's just get the upstream merged first. I can open the backport too |
github-actions
bot
added
area/cli
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Contributor
Author
|
Thank you @dvdksn! Appreciate it |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
<!--Delete sections as needed --> ## Description Final PR to improve the DD IA. Validate test failing due to link that needs fixing in an upstream repo ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review --------- Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com> Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
lorenrh
pushed a commit
to lorenrh/docs
that referenced
this pull request
Nov 12, 2024
<!--Delete sections as needed --> ## Description Final PR to improve the DD IA. Validate test failing due to link that needs fixing in an upstream repo ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review --------- Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com> Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Final PR to improve the DD IA.
Validate test failing due to link that needs fixing in an upstream repo
Related issues or tickets
Reviews