-
Notifications
You must be signed in to change notification settings - Fork 8.1k
engine: minor improvements to rpm-based installation instructions #21380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
09ea538 to
b2d2e74
Compare
|
|
||
| ```console | ||
| $ sudo dnf -y install dnf-plugins-core | ||
| $ sudo dnf install dnf-plugins-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this one I was considering it's probably ok to keep (as this is a distro package, and we have two steps here); mostly for the other steps where they install our packages it's good to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, added this back
b2d2e74 to
64e6f17
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
64e6f17 to
1514b0d
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Supersedes #21382