Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Nov 8, 2024

  • engine: remove -y from fedora (dnf) installation steps
  • engine: enable the systemd service by default after installation

Supersedes #21382

@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/install Relates to installing a product area/api Relates to Docker API docs labels Nov 8, 2024
@netlify
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 1514b0d
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/672e027bcb67a900085fbf4a
😎 Deploy Preview https://deploy-preview-21380--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn force-pushed the engine-install-syncup branch from 09ea538 to b2d2e74 Compare November 8, 2024 11:18

```console
$ sudo dnf -y install dnf-plugins-core
$ sudo dnf install dnf-plugins-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one I was considering it's probably ok to keep (as this is a distro package, and we have two steps here); mostly for the other steps where they install our packages it's good to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, added this back

@dvdksn dvdksn changed the title engine install syncup engine: minor improvements to rpm-based installation instructions Nov 8, 2024
@dvdksn dvdksn force-pushed the engine-install-syncup branch from b2d2e74 to 64e6f17 Compare November 8, 2024 12:13
@dvdksn dvdksn marked this pull request as ready for review November 8, 2024 12:13
@dvdksn dvdksn requested a review from thaJeztah November 8, 2024 12:15
@dvdksn dvdksn removed the area/api Relates to Docker API docs label Nov 8, 2024
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the engine-install-syncup branch from 64e6f17 to 1514b0d Compare November 8, 2024 12:22
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 6af3c4c into docker:main Nov 8, 2024
14 checks passed
@dvdksn dvdksn deleted the engine-install-syncup branch November 8, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon area/install Relates to installing a product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants