Skip to content

feat: sidebar groups #21474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2024
Merged

feat: sidebar groups #21474

merged 3 commits into from
Nov 28, 2024

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Nov 20, 2024 •
edited
Loading

  • add support for sidebar grouping
  • add groups to manuals sections

@netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 0a08b21
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6748760eb61a4d0008100bd4
😎 Deploy Preview https://deploy-preview-21474--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/compose Relates to docker-compose.yml spec or docker-compose binary area/hub Issue affects Docker Hub area/build Relates to Dockerfiles or docker build command area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/subscription Relates to Docker pricing and subscription area/extensions Relates to Docker Extensions area/admin Relates to Docker Admin area/scout Relates to Docker Scout hugo Updates related to hugo area/billing area/accounts Relates to Docker accounts area/build-cloud area/copilot labels Nov 20, 2024
@craig-osterhout
Copy link
Contributor

craig-osterhout commented Nov 20, 2024

Nice! This implementation is a lot cleaner looking. :shipit:
Only issue I see is TCC should be under products.

Some nits / nice to haves:
Incorporate weight or something else to sort the groups. I feel like platform should be at the bottom at least just based on views.
Align the manuals' landing page grids to the groups.

@dvdksn
feat: add support for sidebar grouping
1989620 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn
chore: add sidebar groups to top-level pages in manuals section
b98c303 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn changed the title WIP: sidebar groups feat: sidebar groups Nov 26, 2024
@dvdksn dvdksn marked this pull request as ready for review November 26, 2024 12:50
@dvdksn dvdksn requested a review from a team November 26, 2024 12:50
aevesdocker
aevesdocker previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

(non-blocking: Should the products section be at the top?)

@usha-mandya
Copy link
Member

usha-mandya commented Nov 26, 2024

Looks good @dvdksn. Can we update the landing page to reflect the sidebar grouping? Thanks.

@dvdksn
site: align manuals landing page with new sidebar structure
0a08b21 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested a review from usha-mandya November 28, 2024 13:54
usha-mandya
usha-mandya approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@dvdksn dvdksn merged commit 8a722e7 into docker:main Nov 28, 2024
14 checks passed
@dvdksn dvdksn deleted the sidebar-grouping branch November 28, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@usha-mandya usha-mandya usha-mandya approved these changes

@aevesdocker aevesdocker aevesdocker left review comments

@sarahsanders-docker sarahsanders-docker Awaiting requested review from sarahsanders-docker

@craig-osterhout craig-osterhout Awaiting requested review from craig-osterhout craig-osterhout is a code owner

@crazy-max crazy-max Awaiting requested review from crazy-max

Assignees

No one assigned

Labels

area/accounts Relates to Docker accounts area/admin Relates to Docker Admin area/billing area/build Relates to Dockerfiles or docker build command area/build-cloud area/compose Relates to docker-compose.yml spec or docker-compose binary area/copilot area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/engine Issue affects Docker engine/daemon area/extensions Relates to Docker Extensions area/hub Issue affects Docker Hub area/scout Relates to Docker Scout area/security area/subscription Relates to Docker pricing and subscription hugo Updates related to hugo status/review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dvdksn @craig-osterhout @usha-mandya @aevesdocker