guides: docker build github actions primer #21557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
area/build
crazy-max
reviewed
Dec 3, 2024
dvdksn
commented
Dec 3, 2024
Contributor
Author
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
On second thought, I think I will remove the testing bit, I think I'd like to keep this primer as vanilla as possible.
craig-osterhout
previously approved these changes
Dec 4, 2024
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
Editorial-wise, LGTM.
Left some nits. In addition, the generated text in the left column doesn't format the bullet points, so it's a bit overwhelming. And, it duplicates the intro paragraph that's already displayed.
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic guide for building a basic gha workflow with Docker actions, including
a "full" simple example.