Update file-watch.md: add ignore attribute path #21820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ignore path which is the relative to the path defined in teh same watch
github-actions
bot
added
the
area/compose
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
hi, @aevesdocker can you help review this change |
Contributor
Author
|
hi @glours can you help review this |
glours
approved these changes
Jan 31, 2025
Contributor
glours
left a comment
glours
left a comment
There was a problem hiding this comment.
@hanjie-chen @aevesdocker LGTM when the 2 comments I made will be addressed
Co-authored-by: Guillaume Lours <705411+glours@users.noreply.github.com>
aevesdocker
approved these changes
Feb 3, 2025
Contributor
aevesdocker
left a comment
aevesdocker
left a comment
There was a problem hiding this comment.
Thanks @hanjie-chen, and thanks @glours for the review
Contributor
Author
|
Thanks @aevesdocker and @glours for the reviews ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added some explanation about the
ignoreattribute in the watch rule. I noticed the document says:However, when I deployed it in my project, I found that my container was rebuilding crazily based on the action I defined.
After testing, I discovered that the
ignorepath is actually relative to thepathdefined in the samewatchrule, not the project directory. I also confirmed this with the AI on the Docker Docs website.This PR updates the documentation to clarify this behavior.