build: slsa version parameter for provenance attestations #23796
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
area/build
crazy-max
reviewed
Dec 2, 2025
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Looking at upstream docs https://github.com/moby/buildkit/blob/master/docs/attestations/slsa-provenance.md
Do you think we could add differences in version for builder.id and reproducible? https://github.com/moby/buildkit/blob/master/docs/attestations/slsa-provenance.md#builder-id
Here is the diff with SLSA v1 changes: moby/buildkit@10e725d#diff-5730a9b68d29882a336d985248e9b397b4b08429d63a586b9a9ad7c574a8959a
dvdksn
force-pushed
the
provenance-version-opt
branch
from
288d7f4 to
19ec50f
Compare
crazy-max
reviewed
Dec 2, 2025
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
provenance-version-opt
branch
from
19ec50f to
5f870c5
Compare
crazy-max
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
version=parameter for setting slsa version of provenance attestation.v0.2 (default) or v1
Related issues or tickets