This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] Delete stale containerd object on start failure #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containerd has two objects with regard to containers. There is a "container" object which is metadata and a "task" which is manging the actual runtime state. When docker starts a container, it creartes both the container metadata and the task at the same time. So when a container exits, docker deletes both of these objects as well. This ensures that if, on start, when we go to create the container metadata object in containerd, if there is an error due to a name conflict that we go ahead and clean that up and try again. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 5ba30cd) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @tonistiigi @cpuguy83 PTAL |
|
Interesting; both Power and S390x are failing with; https://jenkins.dockerproject.org/job/Docker-PRs-powerpc/13358/console https://jenkins.dockerproject.org/job/Docker-PRs-s390x/13246/console |
|
From the daemon logs of that test; |
|
I think the remaining failures are flaky tests |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Mar 12, 2019
https://github.com/docker/docker-ce/releases/tag/v18.09.3 The more important fixes in this version: * When copying existing folder, ignore xattr set errors when the target filesystem doesn't support xattr. docker-archive/engine#135 * Graphdriver: fix device mode not being detected if character-device bit is set. docker-archive/engine#160 * Fix nil pointer derefence on failure to connect to containerd. docker-archive/engine#162 * Delete stale containerd object on start failure. docker-archive/engine#154
liske
pushed a commit
to liske/aports
that referenced
this pull request
Apr 7, 2019
https://github.com/docker/docker-ce/releases/tag/v18.09.3 The more important fixes in this version: * When copying existing folder, ignore xattr set errors when the target filesystem doesn't support xattr. docker-archive/engine#135 * Graphdriver: fix device mode not being detected if character-device bit is set. docker-archive/engine#160 * Fix nil pointer derefence on failure to connect to containerd. docker-archive/engine#162 * Delete stale containerd object on start failure. docker-archive/engine#154
seiferteric
pushed a commit
to project-arlo/sonic-buildimage
that referenced
this pull request
Oct 14, 2019
…ll dockers are down except database It's an issue in docker engine, which has been resolved in PR#154 docker-archive/engine#154 And in this commit, we will update the docker to 19.03.0 for this Signed-off-by: Dante (Kuo-Jung) Su <dante.su@broadcom.com> Change-Id: Iecfb7b312abfbcc7741cdcd8b506f9d6c19c4eef
|
Should this bug be fixed in 19.03.6? |
|
Based on the error message it seems like there is still a task running, which this PR does not handle and sounds like a very different problem. |
|
Could you open a new issue with the details? Any clues on how the system got into that state? |
|
Done. Not really. I believe that it was caused by installing some updates (including |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of moby#38364 for 18.09
fixes moby#38346 for 18.09
containerd has two objects with regard to containers.
There is a "container" object which is metadata and a "task" which is
manging the actual runtime state.
When docker starts a container, it creartes both the container metadata
and the task at the same time. So when a container exits, docker deletes
both of these objects as well.
This ensures that if, on start, when we go to create the container metadata object
in containerd, if there is an error due to a name conflict that we go
ahead and clean that up and try again.
Signed-off-by: Brian Goff cpuguy83@gmail.com
(cherry picked from commit 5ba30cd)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)