-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"man docker" displays "This system has been minimized" permanently on non-minimal Ubuntu desktop #639
Comments
|
This is because of the new "minimal" versions of Ubuntu; https://wiki.ubuntu.com/Minimal (also see tianon/docker-brew-ubuntu-core#122 (comment)). On those versions, the FWIW; I can reproduce this on DigitalOcean Ubuntu 18.10 (18.04 does not have the issue); on those instances the |
|
Same issue here after upgrading from 18.10 to 19.04, desktop version, so I guess must be something else |
|
Looks like this needs to be reported to Ubuntu not Docker -- our packages do not treat man pages as something special. |
|
I don't think that this is an Ubuntu problem. The man pages in the .deb that I've downloaded from the Docker repository contain that text: |
|
Same issue. Installed docker-ce-cli from the disco test repo on a fresh desktop install of Ubuntu disco |
|
Not only that but the man output is misleading, since |
|
The unminimize command is something that ubuntu ships to un-minimize such systems; it won't be in the docker-ce-cli package
… On 16 Jun 2019, at 19:19, Elliott Friedman ***@***.***> wrote:
Not only that but the man output is misleading, since 'unminimize' wraps in the man output to 'un-minimize'. Neither command exists:
% dpkg -L docker-ce-cli | grep minimize | wc -l
0
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The minimized Ubuntu images' handling of man pages seems to be a two-step process:
As such, at no point are the packages' actual man pages altered. Furthermore, the My guess is that some part of the Docker packaging pipeline (or one of its dependencies) uses the |
Interesting thought, definitely possible somehow. FWIW, to check, I just tried building the manpages ( |
|
Likely suspect is Which appears to do a "re-encode to utf8", and (at a glance) looks to be using if (@manpages_to_reencode) {
on_items_in_parallel(\@manpages_to_reencode, sub {
for my $manpage (@_) {
my $manpage_tmp = "${manpage}.dh-new";
my $manpage_cmd = ($manpage =~ m{^/}) ? $manpage : "./${manpage}";
doit({ stdout => $manpage_tmp }, 'man', '-l', '--recode', 'UTF-8', $manpage_cmd);
# recode uncompresses compressed pages
my $orig = $manpage;
rm_files($orig) if $manpage =~ s/\.(gz|Z)$//;
rename_path($manpage_tmp, $manpage);
}
# Bulk reset permissions of all re-encoded files
xargs(\@_, 'chmod', '0644', '--');
});
}
} else {
# Should only occur during debhelper building itself (to avoid a B-D on man-db).
warning("man is not available. Skipping re-encode of UTF-8 manpages")
} |
The dh_installman script calls "man" and captures its output to convert manpages to utf8: https://github.com/Debian/debhelper/blob/8523120dccaf5666425109da228b7e1778f15e8b/dh_installman#L298-L316 however, on minimized Ubuntu systems, man is overridden by a script that outputs a warning message ("This system has been minimized by removing packages and content .."). As a result, all man-pages were be overwritten by that message. This patch restores the actual `man` command before running `dh_installman` to work around this issue. addresses docker/for-linux#639 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Opened docker/docker-ce-packaging#343 to fix this (tested it manually, and looks to do the job) |
|
Nice! Good catch. This seems to be an Ubuntu issue then. Your PR seems like a decent workaround (in my opinion) until they sorts it out upstream. I have filed a bug report against Ubuntu's version of the debhelper package: https://bugs.launchpad.net/ubuntu/+source/debhelper/+bug/1833124. It was the most appropriate place I could think of. |
|
Thanks for creating that issue 👍 |
Anyone happen to know where this is? |
|
@jglick It is not packaged, afaik. It seems to be locally ("manually") installed on the Minimal Ubuntu images. |
|
@jglick does Possibly would make sense for Ubuntu to ship that script for the "non-minimized" installs as well (but print a "this system is already unminimized" message, e.g., instead) |
The dh_installman script calls "man" and captures its output to convert manpages to utf8: https://github.com/Debian/debhelper/blob/8523120dccaf5666425109da228b7e1778f15e8b/dh_installman#L298-L316 however, on minimized Ubuntu systems, man is overridden by a script that outputs a warning message ("This system has been minimized by removing packages and content .."). As a result, all man-pages were be overwritten by that message. This patch restores the actual `man` command before running `dh_installman` to work around this issue. addresses docker/for-linux#639 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The dh_installman script calls "man" and captures its output to convert manpages to utf8: https://github.com/Debian/debhelper/blob/8523120dccaf5666425109da228b7e1778f15e8b/dh_installman#L298-L316 however, on minimized Ubuntu systems, man is overridden by a script that outputs a warning message ("This system has been minimized by removing packages and content .."). As a result, all man-pages were be overwritten by that message. This patch restores the actual `man` command before building to work around this issue. addresses docker/for-linux#639 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The dh_installman script calls "man" and captures its output to convert manpages to utf8: https://github.com/Debian/debhelper/blob/8523120dccaf5666425109da228b7e1778f15e8b/dh_installman#L298-L316 however, on minimized Ubuntu systems, man is overridden by a script that outputs a warning message ("This system has been minimized by removing packages and content .."). As a result, all man-pages were be overwritten by that message. This patch restores the actual `man` command before building to work around this issue. addresses docker/for-linux#639 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The dh_installman script calls "man" and captures its output to convert manpages to utf8: https://github.com/Debian/debhelper/blob/8523120dccaf5666425109da228b7e1778f15e8b/dh_installman#L298-L316 however, on minimized Ubuntu systems, man is overridden by a script that outputs a warning message ("This system has been minimized by removing packages and content .."). As a result, all man-pages were be overwritten by that message. This patch restores the actual `man` command before building to work around this issue. addresses docker/for-linux#639 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The dh_installman script calls "man" and captures its output to convert manpages to utf8: https://github.com/Debian/debhelper/blob/8523120dccaf5666425109da228b7e1778f15e8b/dh_installman#L298-L316 however, on minimized Ubuntu systems, man is overridden by a script that outputs a warning message ("This system has been minimized by removing packages and content .."). As a result, all man-pages were be overwritten by that message. This patch restores the actual `man` command before building to work around this issue. addresses docker/for-linux#639 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: e52fa49 Component: packaging
The dh_installman script calls "man" and captures its output to convert manpages to utf8: https://github.com/Debian/debhelper/blob/8523120dccaf5666425109da228b7e1778f15e8b/dh_installman#L298-L316 however, on minimized Ubuntu systems, man is overridden by a script that outputs a warning message ("This system has been minimized by removing packages and content .."). As a result, all man-pages were be overwritten by that message. This patch restores the actual `man` command before building to work around this issue. addresses docker/for-linux#639 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit e52fa49)
The dh_installman script calls "man" and captures its output to convert manpages to utf8: https://github.com/Debian/debhelper/blob/8523120dccaf5666425109da228b7e1778f15e8b/dh_installman#L298-L316 however, on minimized Ubuntu systems, man is overridden by a script that outputs a warning message ("This system has been minimized by removing packages and content .."). As a result, all man-pages were be overwritten by that message. This patch restores the actual `man` command before building to work around this issue. addresses docker/for-linux#639 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit e52fa49) Upstream-commit: 8007c3ea8df04d642addf9bb786ea47f27d28103 Component: packaging
|
Seems bad that I can't even get man pages to work by installing them!? I don't want to unminimize, I just want man pages. |
|
What version of docker do you have installed? This issue should be fixed by docker/docker-ce-packaging#358 (and used for the current 19.03.x packages) |
|
Let me close this ticket for now, as it looks like it went stale. |
Expected behavior
man dockershould display the Docker manpage.Actual behavior
There's no such command on Ubuntu desktop systems afaik. All other manpages are working as expected.
Steps to reproduce the behavior
Invoke
man dockeron Ubuntu 18.10 after installing it following the installation guide on the website.Output of
docker version:Output of
docker info:Additional environment details (AWS, VirtualBox, physical, etc.)
./.
The text was updated successfully, but these errors were encountered: