Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker can't start after add new mirrors to the "Registry mirrors" #2537

Closed
BadTudou opened this issue Jan 30, 2018 · 11 comments

Comments

@BadTudou
Copy link

commented Jan 30, 2018

Expected behavior

Docker can't start after add new mirrors to the "Registry mirrors"

Information

macOS High Sierra 10.13.3

Community Edition
Version 17.12.0-ce-mac49 (21995)
Channel: stable
f50f37646d

Steps to reproduce the behavior

  1. Add a new registry-mirrors to Docker, Keep the input box to get the focus, then click "Apply & Restart" button
    image
  2. Docker auto restart, got the error
    image
  3. After that, the content of ' ~/.docker/daemon.json' was:
{
  "debug" : true,
  "registry-mirrors" : [
    ""
  ],
  "experimental" : true
}

Manual repair

vi ~/.docker/daemon.json
  1. Add new registry-mirrors to the ' ~/.docker/daemon.json', like this:
{
  "debug" : true,
  "registry-mirrors" : [
    "http://4e05aeb3.m.daocloud.io"
  ],
  "experimental" : true
}
  1. Restart Docker, There's nothing wrong with it
@hoiyd

This comment has been minimized.

Copy link

commented Jan 31, 2018

Having exactly the same issue

macOS Sierra
version 10.12.6

Community Edition
Version 17.12.0-ce-mac49 (21995)
Channel: stable
f50f37646d

@akimd

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2018

Good catch! I can reproduce it.

@akimd

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2018

@aduermael Could you have a look at the GUI side of it? I'll see if I can do something about the daemon being broken.

@aduermael

This comment has been minimized.

Copy link

commented Jan 31, 2018

@akimd I'm on it!

@aduermael aduermael self-assigned this Jan 31, 2018

@akimd

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2018

You're fast :)

@aduermael

This comment has been minimized.

Copy link

commented Jan 31, 2018

I opened a PR to fix the issue on the UI side.

But discovered something else:

  • Enter a fake registry mirror (e.g. foo)
  • Apply changes

The daemon can't start, the panel remains disabled so there's no way to update the value... (only option is to manually edit daemon.json).

The daemon should be able to inform the GUI when it can't start. When in that situation, the daemon settings should be accessible. (I opened an internal issue to discuss this @akimd)

@pgayvallet

This comment has been minimized.

Copy link

commented Feb 6, 2018

@aduermael what do you mean "fake" registry mirror ? if that's juste invalid format, we should be able to perform simple validation, no ?

@pgayvallet

This comment has been minimized.

Copy link

commented Feb 8, 2018

Fixed in latest edge (18.02.0-ce-mac52)

@ifeengwd2012

This comment has been minimized.

Copy link

commented Feb 27, 2018

Thanks!

@akimd

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2018

Let's close this, thanks for having checked!

@razertory

This comment has been minimized.

Copy link

commented Oct 2, 2018

It's exactly an UI bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.