Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-address-pools can not be specified in configuration #3108

Open
andrewyager opened this issue Jul 21, 2018 · 15 comments

Comments

Projects
None yet
8 participants
@andrewyager
Copy link

commented Jul 21, 2018

  • [ X ] I have tried with the latest version of my channel (Edge)
  • [ X ] I have uploaded Diagnostics
  • Diagnostics ID: 4C64E62D-388C-4A11-8FA0-E652F118050C/20180721101945

Expected behavior

According to the milestone release, default-address-pools should be supported in the 18.06 release (docker/cli#818, moby/moby#36396)

Actual behavior

Docker For Mac will not validate and accept this in the configuration

Information

  • problem is new for this new feature
  • macOS Version: 10.13.6

Diagnostic logs

Docker for Mac: version 18.06.0-ce-rc3-mac68 (26342)

Steps to reproduce the behavior

  1. Go to advanced settings
  2. attempt to add default address pools config:
{
  "debug" : true,
  "experimental" : true,
  "default-address-pools": [
     {
        "base": "10.225.0.0/16",
         "size": 24,
     }]
}

displays:

"default-address-pools":
  Invalid option
@jverdeyen

This comment has been minimized.

Copy link

commented Jul 24, 2018

@andrewyager try default-address-pool vs. default-address-pools.

@andrewyager

This comment has been minimized.

Copy link
Author

commented Jul 24, 2018

Same issue with default-address-pool.

@jverdeyen

This comment has been minimized.

Copy link

commented Jul 24, 2018

I'm using DOCKER_EXTRA_ARGS="--default-address-pool base=172.16.0.0/12,size=24" in /etc/default/docker and it's working (on Linux).

@andrewyager

This comment has been minimized.

Copy link
Author

commented Jul 24, 2018

Is there an equivalent option in Docker for Mac? Happy to change it, however I don't think you can add additional arguments to the engine startup?

@davidlemaitre

This comment has been minimized.

Copy link

commented Jul 25, 2018

@andrewyager Your JSON config is invalid, remove the last comma

@andrewyager

This comment has been minimized.

Copy link
Author

commented Jul 25, 2018

The perils of not copy-pasting and retyping.

This is invalid according to the validator

{
  "debug" : true,
  "experimental" : true,
  "default-address-pool": [
     {
        "base": "10.225.0.0/16",
         "size": 24
     }]
}

This is also invalid:

{
  "debug" : true,
  "experimental" : true,
  "default-address-pools": [
     {
        "base": "10.225.0.0/16",
         "size": 24
     }]
}

The config linter in the docker for mac toolbox does not understand either of these parameter options.

@davidlemaitre

This comment has been minimized.

Copy link

commented Jul 25, 2018

I'm not using Docker for Mac, I'm on Ubuntu 16.04 and this config works:

{ "default-address-pools": [ { "base": "172.80.0.0/16", "size": 24 }] }

@andrewyager

This comment has been minimized.

Copy link
Author

commented Jul 25, 2018

Yes. I suspect the issue is specific to docker-for-mac, rather than docker itself which is why the issue is posted in the docker/for-mac tree!

@andrewyager andrewyager changed the title default-address-pools can not be specified in configruation default-address-pools can not be specified in configuration Jul 25, 2018

@defn

This comment has been minimized.

Copy link

commented Jul 25, 2018

You can bypass the GUI for configuring daemon.json by editing ~/.docker/daemon.json. Restart Docker will use your default address pools but the GUI will continue to complain.

The ability to edit daemon.json was released with 17.09 https://docs.docker.com/docker-for-mac/release-notes/#docker-community-edition-17090-ce-mac33-2017-10-03

Here's my daemon.json:

> cat ~/.docker/daemon.json
{
  "debug" : true,
  "experimental" : true,
  "default-address-pools": [
    {
      "scope": "local",
      "base": "172.30.0.0/16",
      "size": 24
    }
  ]
}
@andrewyager

This comment has been minimized.

Copy link
Author

commented Jul 26, 2018

The above process works 100%. The issue then remains the originally reported one, namely that the docker-for-mac GUI doesn't correctly validate the configuration option, even though it is supported and will need to be updated.

@docker-desktop-robot

This comment has been minimized.

Copy link
Collaborator

commented Oct 24, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale comment.
Stale issues will be closed after an additional 30d of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle stale

@gee-forr

This comment has been minimized.

Copy link

commented Nov 22, 2018

Just chiming in that this issue is still around in Docker For Mac 2.0.0.0-mac78.

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

/lifecycle frozen

@defn

This comment has been minimized.

Copy link

commented Jan 18, 2019

I was able to paste a daemon.json config with pools into the Docker for Mac GUI using version 2.0.0.2 (30215) today. Verified by deleting my ~/.docker/daemon.json and restarting Docker.

@veepee78

This comment has been minimized.

Copy link

commented Mar 1, 2019

Looks like this option is completely missing in windows server version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.