New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker doesn't upgrade #1043

Closed
fayep opened this Issue Aug 27, 2017 · 29 comments

Comments

@fayep

fayep commented Aug 27, 2017

Expected behavior

When answering "yes" to the prompt to continue with the install, the install continues

Actual behavior

Installation cancelled is received whether yes or no is clicked.

Information

Docker was installed using the download from the website, which always goes through.
This may be an artifact of having had old versions of docker on here, I've upgraded from before the versioning changed. I suspect that installing a newer version hasn't reset this flag.
I have attempted to uninstall docker from the uninstall settings and that makes no difference - if there is no Docker listed in Apps & Features then it still says Msi based installation found.
By finding and running the installer exe manually from a console:

[12:28:52.169] [InstallHandler] Not run as admin, relaunching with UAC prompt
[12:28:56.712] [InstallHandler] No d4w installation found
[12:28:56.725] [InstallHandler] Using embedded package
[12:28:56.876] [InstallWorkflow] Using package: res:d4w
[12:28:56.878] [InstallWorkflow] Downloading
[12:28:57.256] [InstallWorkflow] Exracting manifest
[12:28:57.285] [InstallWorkflow] Checking prerequisites
[12:28:57.310] [InstallWorkflow] Msi based installation found, prompting user
[12:28:59.843] [InstallWorkflow] Uninstalling msi based installation, with special flag
[12:28:59.915] [InstallWorkflow] MSI Uninstall failed

If you can point me to the logs for the MSI Uninstall or give me info to trigger manually, I'm happy to see what happens. I suspect that I have bad registry data, but it would be good to know how the "Msi based installation" is found

Steps to reproduce the behavior

  1. Install docker from website
  2. Upgrade appears in docker
  3. Attempt to install upgrade. Fails.
  4. repeat from 1.

@fayep fayep changed the title from Docker doesn to Docker doesn't upgrade Aug 27, 2017

@beiriannydd

This comment has been minimized.

beiriannydd commented Aug 27, 2017

Other things I've tried. Downloading InstallDocker.msi and repairing it, then running this, removing it then running this. All give the same result.

@luke-barnett

This comment has been minimized.

luke-barnett commented Sep 8, 2017

I'm having the same issue described here.

I've run the script from here:

https://success.docker.com/KBase/How_to_completely_remove_Docker

Restarted my machine and when going to install again fresh, it is asking me if I want to do an upgrade. Hitting either yes or not results in a canceled installation.

@selner

This comment has been minimized.

selner commented Sep 16, 2017

I was having the same issue described here.

However, I did manage to work around the issue by running the legacy MSI installer for the stable channel instead from https://download.docker.com/win/stable/InstallDocker.msi.

@kamkie

This comment has been minimized.

kamkie commented Oct 3, 2017

I also have this problem and now msi installer is not working (17.09)

@Dante-101

This comment has been minimized.

Dante-101 commented Oct 5, 2017

Same here. The .msi installer ended up uninstalling Docker and then crashed. Running it again brings up the installer dialog box for a split second and the installer quits.

Another odd thing is that the .msi installer is just 256 KB in size. Is it a bug from the build system or has Docker shifted to online installers?

@gtardif Can you please help?

@gtardif

This comment has been minimized.

Contributor

gtardif commented Oct 6, 2017

This .msi installer has been replaced by another one a couple of versions ago (hence the small .msi you have that should just get you to the new installer).
You should try downloading the installer form here :
https://download.docker.com/win/stable/Docker%20for%20Windows%20Installer.exe

@kauhat

This comment has been minimized.

kauhat commented Oct 6, 2017

Here's what happens when I run the LightweightInstaller executable for 17.09.0-ce-win33 on my work machine. It happens whether Docker is installed or not.

The most recent version I have installed is 17.06.2-ce-win27 from the MSI installer.

PS C:\Users\jack.fletcher\Downloads> & '.\Docker for Windows Installer.exe'
PS C:\Users\jack.fletcher\Downloads> [16:28:35.210] [InstallHandler] No d4w installation found
[16:28:35.214] [InstallHandler] Using embedded package
[16:28:35.334] [InstallWorkflow] Using package: res:d4w
[16:28:35.335] [InstallWorkflow] Downloading
[16:28:40.026] [InstallWorkflow] Exracting manifest
[16:28:40.067] [InstallWorkflow] Checking prerequisites
[16:28:40.089] [InstallWorkflow] Msi based installation found, prompting user
[16:28:41.013] [InstallWorkflow] Uninstalling msi based installation, with special flag
[16:28:41.091] [InstallWorkflow] MSI Uninstall failed

This is on 10 Pro x64, build no. 15063.608. Let me know if there's anymore details I can provide.

I've uploaded diagnostic report 606F2D48-4906-4849-9504-A14C638AC446/2017-10-06_16-33-36 from the installable 17.06 version if that helps!

@Jefiozie

This comment has been minimized.

Jefiozie commented Oct 7, 2017

Having the same issue when upgrading to 17.09-CE-win34 (13622)

  • Used the new installer as mentioned by @gtardif .. didn't work,
  • removed all stuff via powershell script , no success.

Cannot find anything on my HDD or in the Register any workaround or things I missed to fix this.?

@fayep

This comment has been minimized.

fayep commented Oct 8, 2017

My output is identical to Kauhat's and this is the same behavior as the ordinary upgrade (except you only get to see the installation cancelled window) and not the log output. How do we manually uninstall because even if I use add-remove software, it still passes the "MSI based installation found" check (perhaps the check is in error, or the uninstall is leaving artifacts behind?)

If I run the msi uninstaller with msiexec:
PS C:\Users\faye\Downloads> msiexec.exe /x '{C482546D-67BB-41BD-8E28-A71A002BC14
6}' /qn

silently exits

PS C:\Users\faye\Downloads> msiexec.exe /x '{C482546D-67BB-41BD-8E28-A71A002BC14
6}' /qb

requests permission and uninstalls.

@abobwhite

This comment has been minimized.

abobwhite commented Oct 8, 2017

What is going on here!? I haven't been able to cleanly upgrade Docker on Windows since it first became available. Back in June I was able to manually cleanup some registry keys and it worked, now I get the same results as the folks above. How can something so basic go being broken for so long? Most of 2017....

@jmail

This comment has been minimized.

jmail commented Oct 10, 2017

Same issue my side - I am having this issue since July I think. I finally removed all but there are still some entries and infos on the machine so installer knows docker was installed and asking for upgrade - what a mess. I can't work with my customer as they only work on dockers

@jasonbivins jasonbivins self-assigned this Oct 11, 2017

@Jefiozie

This comment has been minimized.

Jefiozie commented Oct 15, 2017

@jasonbivins Any updates on this issue? Or a workaround to fix the issue?

Thanks 👍

@jasonbivins

This comment has been minimized.

jasonbivins commented Oct 17, 2017

Hi @Jefiozie
Look for this registry key and remove it if it exists. Then try to install using the legacy .msi
Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall

@Jefiozie

This comment has been minimized.

Jefiozie commented Oct 17, 2017

Hi @jasonbivins Thanks for your reply.

What key should I look for the docker key? I don't see that one in my registry.
Thanks.

@pjmolina

This comment has been minimized.

pjmolina commented Oct 17, 2017

Hi @jasonbivins
Tried your approach:

  • Removed registry key: {C482546D-67BB-41BD-8E28-A71A002BC146}
  • Tried yo reinstall with the same result: installation cancelled.

Just to be sure: Could you provide a explicit link to the legacy .msi installer you are referring?
Any other key to delete or workaround to force a clean install?

Thanks

@Jefiozie

This comment has been minimized.

Jefiozie commented Oct 17, 2017

Hi @jasonbivins

Missed the key but the comment of @pjmolina helped me.
Same result as him by the way so this was not enough apparently.

@bbqduc

This comment has been minimized.

bbqduc commented Oct 17, 2017

I had this issue as well and was able to resolve it thanks to this https://forums.docker.com/t/cannot-uninstall-docker-for-windows/15661/23 wonderful comment!

In my case Process Monitor showed the installer reading HKCR\Installer\UpgradeCodes\9CA3F2E62DBFCA74DB9BD0384695C460. Deleting that manually solved the problem for me. Not sure if the key will be different on other machines.

@Jefiozie

This comment has been minimized.

Jefiozie commented Oct 17, 2017

@bbqduc Thanks this resolved the issue for me!

@jmail

This comment has been minimized.

jmail commented Oct 17, 2017

@bbqduc Thanks - that resolved my problem as well

@pjmolina

This comment has been minimized.

pjmolina commented Oct 17, 2017

@bbqduc Thank you! Your dirty hack works here also! ;-)

@phantase

This comment has been minimized.

phantase commented Oct 17, 2017

@bbqduc Thanks, solved my problem also, except that after reinstalling Docker, Avast just removed it (IDP.Generic treat), I had to add an exception to Docker to have it working.

@tiggi7

This comment has been minimized.

tiggi7 commented Nov 11, 2017

Thi worked also for me.
Thanks a lot.

@sachin-gupta

This comment has been minimized.

sachin-gupta commented Nov 30, 2017

As per @bbqduc and wonderful comment here and following steps this issue is solved after failing 100 times 😄

  • Export backup of registry key HKCR\Installer\UpgradeCodes\9CA3F2E62DBFCA74DB9BD0384695C460 (was same on my computer)
  • Open regedit.exe in windows and delete entire registry key group
  • Download Edge Release full installer only from site (comes with weekly patches)
  • Disable all firewall and antivirus, Stop docker from taskbar and windows service from services.msc
  • Open command print and run .\"Docker for Windows.exe" and it should complete setup
@jasonbivins

This comment has been minimized.

jasonbivins commented Nov 30, 2017

Hi @sachin-gupta
Thanks for putting that together ! I'll make sure it makes it into a KB in the next few days

@giphoo

This comment has been minimized.

giphoo commented Dec 4, 2017

@bbqduc it work for me. thank you!!!

@svassaux

This comment has been minimized.

svassaux commented Dec 23, 2017

I have started on a new machine, I had not those keys people are referring to and thus I can't remove them. installer fails. Nothing to remove.

@abobwhite

This comment has been minimized.

abobwhite commented Dec 30, 2017

@sachin-gupta OMG thank you! I have been fighting this for months. Your steps worked perfectly!

@udif

This comment has been minimized.

udif commented Feb 21, 2018

I've also reached this registry key independently and hit this github issue only after googling 9CA3F2E62DBFCA74DB9BD0384695C460 just to be sure.
My original problem was the the docker installer decided I already have the latest version, even though it was uninstalled.
For the record, as it may help other people, here is how I got here:

  1. I ran https://docs.microsoft.com/en-us/sysinternals/downloads/procmon and captured events while running the installer, then stopped capturing (CTRL+E).
  2. I then filtered all events but the successfull registry operations coming from the Docker install process, who did not return a NAME NOT FOUND result.
  3. I searched for 'docker' within the remaining results, and nuked any registry entry found, each time rerunning the installer to see if it would succeed.
  4. After removing all docker registry entries, it at least tried installing something, but then got the 'install aborted' message. I then browsed the entries looking for entries with a long unique hex ID. This is when I found 9CA3F2E62DBFCA74DB9BD0384695C460 .
  5. After googling it and finding it here, I nuked it too, and solved my problem.

Hope this may help people with future problems.

@docker-for-desktop-robot

This comment has been minimized.

Collaborator

docker-for-desktop-robot commented Jul 31, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale comment.
Stale issues will be closed after an additional 30d of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment