Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty CreatedAt #107

Merged
merged 7 commits into from Sep 17, 2018

Conversation

Projects
None yet
3 participants
@cblomart
Copy link
Contributor

cblomart commented Aug 5, 2018

Empty CreatedAt values causes errors in docker

@cblomart

This comment has been minimized.

Copy link
Contributor Author

cblomart commented Aug 9, 2018

Should "Status" be ignored too?
Following docker documentation it is optional too.

Ignore empty volume status too
Signed-off-by: Cedric Blomart <cblomart@gmail.com>
@m4r10k

This comment has been minimized.

Copy link

m4r10k commented Sep 4, 2018

Thank you for your PR! Today I wrote my first Docker volume plugin and it takes me some time to figure that out. Would be nice if this one gets merged soon! Thanks for pointing out the problem.

cblomart added some commits Sep 10, 2018

@cblomart

This comment has been minimized.

Copy link
Contributor Author

cblomart commented Sep 11, 2018

@dave-tucker, as i see some pulls have been merged, any ideas why build fails on "+fmt"? (from travis logs)

@dave-tucker

This comment has been minimized.

Copy link
Member

dave-tucker commented Sep 11, 2018

@cblomart nope. that's why I'm hesitant to merge this at the moment. I should have some time to take a look properly later this week.

@dave-tucker

This comment has been minimized.

Copy link
Member

dave-tucker commented Sep 11, 2018

In the meantime you could try running gofmt -w -s on the files that are misbehaving.
https://golang.org/cmd/gofmt/

@cblomart

This comment has been minimized.

Copy link
Contributor Author

cblomart commented Sep 11, 2018

@dave-tucker : thanks for the advise... i bluntly gofmt all files and it goes further. I guess i now have the latest test issues (tar.Header).

cblomart and others added some commits Sep 14, 2018

Blomart Cedric Blomart Cedric
@cblomart

This comment has been minimized.

Copy link
Contributor Author

cblomart commented Sep 14, 2018

Ok apparently some part used by docker compress are now only in newer versions of golang so updating golang to 1.11 solved the case.
... still "go fmt" in this version didn't like one test file so i gofmted it.

Builds now :D

@cblomart

This comment has been minimized.

Copy link
Contributor Author

cblomart commented Sep 17, 2018

@dave-tucker: looks good now... is the golang upgrade worrying?

@dave-tucker

This comment has been minimized.

Copy link
Member

dave-tucker commented Sep 17, 2018

Nope. Thanks @cblomart.

@dave-tucker
Copy link
Member

dave-tucker left a comment

LGTM

@dave-tucker dave-tucker merged commit 39aeefe into docker:master Sep 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.