New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Stage builds on docker hub #1039

Closed
captncraig opened this Issue May 9, 2017 · 41 comments

Comments

Projects
None yet
@captncraig

captncraig commented May 9, 2017

In trying to run multi-stage builds in a docker hub automated build:

Error parsing reference: "golang:1.7.3 as builder" is not a valid repository/tag: invalid reference format

It looks like docker hub is not using the version of docker that supports this yet. Is there a timeline for when support will be availible?

@pkennedyr

This comment has been minimized.

Show comment
Hide comment
@pkennedyr

pkennedyr May 9, 2017

Thanks for the feedback. The Docker Hub and Docker Cloud automated build service will be adding support for multi-stage builds when this feature graduates to the stable channel (currently targeted for June as part of the 17.06 release).

For more information on the Docker time-based release schedule, please see: https://docs.docker.com/engine/installation/#time-based-release-schedule

pkennedyr commented May 9, 2017

Thanks for the feedback. The Docker Hub and Docker Cloud automated build service will be adding support for multi-stage builds when this feature graduates to the stable channel (currently targeted for June as part of the 17.06 release).

For more information on the Docker time-based release schedule, please see: https://docs.docker.com/engine/installation/#time-based-release-schedule

@captncraig

This comment has been minimized.

Show comment
Hide comment
@captncraig

captncraig May 9, 2017

Thank you for the prompt feedback! Feel free to close this issue unless you'd rather leave it open until that release.

captncraig commented May 9, 2017

Thank you for the prompt feedback! Feel free to close this issue unless you'd rather leave it open until that release.

rakshazi added a commit to rakshazi/slim-skeleton that referenced this issue Jun 13, 2017

@medyagh

This comment has been minimized.

Show comment
Hide comment
@medyagh

medyagh Jun 14, 2017

@pkennedyr are we there there?
(aka is it there multistage on dockerhub yet?)

medyagh commented Jun 14, 2017

@pkennedyr are we there there?
(aka is it there multistage on dockerhub yet?)

@captncraig

This comment has been minimized.

Show comment
Hide comment
@captncraig

captncraig commented Jun 14, 2017

@pkennedyr

This comment has been minimized.

Show comment
Hide comment
@pkennedyr

pkennedyr Jun 14, 2017

[UPDATE] Multi-stage builds are now available in Docker Cloud as part of the 5-30-2017 release:
https://forums.docker.com/t/docker-cloud-product-update-5-30-2017/32938

To take advantage of multi-stage builds (in Docker Cloud), select Edge (17.05.0-ce) as the Docker version of an automated repository.

We encourage you to try out Docker Cloud as this is where you will find support for this and many other autobuild features.

pkennedyr commented Jun 14, 2017

[UPDATE] Multi-stage builds are now available in Docker Cloud as part of the 5-30-2017 release:
https://forums.docker.com/t/docker-cloud-product-update-5-30-2017/32938

To take advantage of multi-stage builds (in Docker Cloud), select Edge (17.05.0-ce) as the Docker version of an automated repository.

We encourage you to try out Docker Cloud as this is where you will find support for this and many other autobuild features.

@medyagh

This comment has been minimized.

Show comment
Hide comment
@medyagh

medyagh Jun 14, 2017

@pkennedyr is the multi stage build still scheduled for docker hub for this june ? or has that been cancelled and only available in docker cloud ?

medyagh commented Jun 14, 2017

@pkennedyr is the multi stage build still scheduled for docker hub for this june ? or has that been cancelled and only available in docker cloud ?

laugimethods added a commit to Logimethods/docker-eureka that referenced this issue Jun 15, 2017

wongwill86 added a commit to wongwill86/air-tasks that referenced this issue Jun 15, 2017

apk added a commit to apk/c-utils that referenced this issue Jun 28, 2017

aenv: add --reaper-fork
Now, if dockerhub had multi-stage builds I could
actually go ahead and use this in my images.

docker/hub-feedback#1039
@drasko

This comment has been minimized.

Show comment
Hide comment
@drasko

drasko Jun 30, 2017

What's the conclusion - is Docker Hub getting multi-stage builds any time soon?

drasko commented Jun 30, 2017

What's the conclusion - is Docker Hub getting multi-stage builds any time soon?

@pkennedyr

This comment has been minimized.

Show comment
Hide comment
@pkennedyr

pkennedyr Jun 30, 2017

[UPDATE to earlier post] Docker Hub will in fact support multi-stage builds when the automated build system is upgraded to 17.06.01 (target ETA July). We apologize for the confusion.

pkennedyr commented Jun 30, 2017

[UPDATE to earlier post] Docker Hub will in fact support multi-stage builds when the automated build system is upgraded to 17.06.01 (target ETA July). We apologize for the confusion.

@milsonian

This comment has been minimized.

Show comment
Hide comment
@milsonian

milsonian Jun 30, 2017

I'm a bit confused...

The biggest feature in 17.06 CE is that multi-stage builds, announced in April at DockerCon, have come to the stable release.

So is Hub not going to go to 17.06 at any point? Or are you pulling the feature from CE / will it be flagged / etc.?

milsonian commented Jun 30, 2017

I'm a bit confused...

The biggest feature in 17.06 CE is that multi-stage builds, announced in April at DockerCon, have come to the stable release.

So is Hub not going to go to 17.06 at any point? Or are you pulling the feature from CE / will it be flagged / etc.?

@pkennedyr

This comment has been minimized.

Show comment
Hide comment
@pkennedyr

pkennedyr Jun 30, 2017

@milsonian Apologies for the confusion, with availability of multi-stage builds in 17.06, this feature will also be available in Docker Hub when the corresponding upgrade to 17.06 occurs (ETA July).

Note: Docker Cloud provides the ability to specify the Docker version (Stable or Edge) to use for an automated build, which enables access to the multi-stage build feature via the Edge channel today.

pkennedyr commented Jun 30, 2017

@milsonian Apologies for the confusion, with availability of multi-stage builds in 17.06, this feature will also be available in Docker Hub when the corresponding upgrade to 17.06 occurs (ETA July).

Note: Docker Cloud provides the ability to specify the Docker version (Stable or Edge) to use for an automated build, which enables access to the multi-stage build feature via the Edge channel today.

@milsonian

This comment has been minimized.

Show comment
Hide comment
@milsonian

milsonian Jul 1, 2017

That's great, thanks for the clarification @pkennedyr!

milsonian commented Jul 1, 2017

That's great, thanks for the clarification @pkennedyr!

@agc93

This comment has been minimized.

Show comment
Hide comment
@agc93

agc93 Jul 7, 2017

@pkennedyr Any update on when in July we can expect this feature on the Hub?

agc93 commented Jul 7, 2017

@pkennedyr Any update on when in July we can expect this feature on the Hub?

@pkennedyr

This comment has been minimized.

Show comment
Hide comment
@pkennedyr

pkennedyr Jul 7, 2017

Current ETA: late July

We are currently awaiting availability of 17.06.01 CE GA, which includes a bug fix for multi-stage builds. Once available, we will update the Automated Build system with this new version and multi-stage builds will be available in Docker Hub.

pkennedyr commented Jul 7, 2017

Current ETA: late July

We are currently awaiting availability of 17.06.01 CE GA, which includes a bug fix for multi-stage builds. Once available, we will update the Automated Build system with this new version and multi-stage builds will be available in Docker Hub.

@drasko

This comment has been minimized.

Show comment
Hide comment
@drasko

drasko Jul 23, 2017

@pkennedyr any updates on the ETA?

drasko commented Jul 23, 2017

@pkennedyr any updates on the ETA?

@mghazizadeh

This comment has been minimized.

Show comment
Hide comment
@mghazizadeh

mghazizadeh Jul 25, 2017

@drasko we are waiting GA release of 17.06.1 at the end of this month. We will update this thread in early August once the build service has been updated to that version.

mghazizadeh commented Jul 25, 2017

@drasko we are waiting GA release of 17.06.1 at the end of this month. We will update this thread in early August once the build service has been updated to that version.

@medyagh

This comment has been minimized.

Show comment
Hide comment
@medyagh

medyagh Jul 26, 2017

sorry not related tot this issue @mghazizadeh we have the same name ??? my name is Medya Ghazizadeh ! I never met anyone with same name with me.

medyagh commented Jul 26, 2017

sorry not related tot this issue @mghazizadeh we have the same name ??? my name is Medya Ghazizadeh ! I never met anyone with same name with me.

@llitfkitfk

This comment has been minimized.

Show comment
Hide comment
@llitfkitfk

llitfkitfk Aug 1, 2017

currently you can use docker cloud for automated builds using multistage build (need config docker-ce edge version)

https://cloud.docker.com/app/your-username/repository/docker/your-username/image-name/builds/edit

llitfkitfk commented Aug 1, 2017

currently you can use docker cloud for automated builds using multistage build (need config docker-ce edge version)

https://cloud.docker.com/app/your-username/repository/docker/your-username/image-name/builds/edit

prymitive added a commit to cloudflare/unsee that referenced this issue Aug 9, 2017

prymitive added a commit to cloudflare/unsee that referenced this issue Aug 9, 2017

prymitive added a commit to cloudflare/unsee that referenced this issue Aug 9, 2017

@ibnesayeed

This comment has been minimized.

Show comment
Hide comment
@ibnesayeed

ibnesayeed Aug 10, 2017

@thaJeztah: ... and resulting images are also pushed to the same (Docker Hub) registry ...

Thanks, I didn't know about it. What would happen if we set up automated builds for the same image in both the places (i.e., hub and cloud)?

ibnesayeed commented Aug 10, 2017

@thaJeztah: ... and resulting images are also pushed to the same (Docker Hub) registry ...

Thanks, I didn't know about it. What would happen if we set up automated builds for the same image in both the places (i.e., hub and cloud)?

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Aug 12, 2017

Member

If automated builds are configured on both, it's whichever was triggered last that pushes the image (well, they both push, but the last one will replace the previous one)

Looks like something we need to point out in the documentation (i.e. both Cloud and Hub using the same registry)

Member

thaJeztah commented Aug 12, 2017

If automated builds are configured on both, it's whichever was triggered last that pushes the image (well, they both push, but the last one will replace the previous one)

Looks like something we need to point out in the documentation (i.e. both Cloud and Hub using the same registry)

@ibnesayeed

This comment has been minimized.

Show comment
Hide comment
@ibnesayeed

ibnesayeed Aug 12, 2017

Yes, this should be documented. I think there are many confusing bits, especially for those who are new to the ecosystem and did not witness it evolving. For example, currently there are three places to publish images, Hub, Store, and Cloud while they are all related and share pieces. Their separate distinguishing role might not be very clear to people.

ibnesayeed commented Aug 12, 2017

Yes, this should be documented. I think there are many confusing bits, especially for those who are new to the ecosystem and did not witness it evolving. For example, currently there are three places to publish images, Hub, Store, and Cloud while they are all related and share pieces. Their separate distinguishing role might not be very clear to people.

@gesellix

This comment has been minimized.

Show comment
Hide comment
@gesellix

gesellix Aug 16, 2017

FYI: https://blog.docker.com/2017/08/docker-enterprise-edition-17-06/
The countdown to multi-stage builds being available on Docker Hub has started ;-)

gesellix commented Aug 16, 2017

FYI: https://blog.docker.com/2017/08/docker-enterprise-edition-17-06/
The countdown to multi-stage builds being available on Docker Hub has started ;-)

@ph-One

This comment has been minimized.

Show comment
Hide comment
@ph-One

ph-One Aug 18, 2017

17.06.1-ce has dropped. Anxiously awaiting to see all my broken [multi-stage] builds start to run.

ph-One commented Aug 18, 2017

17.06.1-ce has dropped. Anxiously awaiting to see all my broken [multi-stage] builds start to run.

@mghazizadeh

This comment has been minimized.

Show comment
Hide comment
@mghazizadeh

mghazizadeh Aug 18, 2017

@ph-One team is working on the upgrade for builders, please stay tuned.

mghazizadeh commented Aug 18, 2017

@ph-One team is working on the upgrade for builders, please stay tuned.

@cglewis

This comment has been minimized.

Show comment
Hide comment
@cglewis

cglewis Aug 21, 2017

works on Docker Hub now for me.

cglewis commented Aug 21, 2017

works on Docker Hub now for me.

@ibnesayeed

This comment has been minimized.

Show comment
Hide comment
@ibnesayeed

ibnesayeed Aug 21, 2017

@cglewis: works on Docker Hub now for me.

I don't see any option to specify build-args #508 though.

ibnesayeed commented Aug 21, 2017

@cglewis: works on Docker Hub now for me.

I don't see any option to specify build-args #508 though.

@pkennedyr

This comment has been minimized.

Show comment
Hide comment
@pkennedyr

pkennedyr Aug 21, 2017

The Automated Build system has been updated with 17.06.01 CE, which enables multi-stage builds in Docker Hub.

pkennedyr commented Aug 21, 2017

The Automated Build system has been updated with 17.06.01 CE, which enables multi-stage builds in Docker Hub.

@gesellix

This comment has been minimized.

Show comment
Hide comment
@gesellix

gesellix Aug 21, 2017

It worked - but now it's reverted to Docker EE 17.03.1? See https://hub.docker.com/r/gesellix/wait-for/builds/btfvjxwqgzrhdhxxz55ilj6/ for an example.

gesellix commented Aug 21, 2017

It worked - but now it's reverted to Docker EE 17.03.1? See https://hub.docker.com/r/gesellix/wait-for/builds/btfvjxwqgzrhdhxxz55ilj6/ for an example.

@krambox

This comment has been minimized.

Show comment
Hide comment
@wilsontayar

This comment has been minimized.

Show comment
Hide comment
@wilsontayar

wilsontayar Aug 21, 2017

@gesellix @krambox The same thing is happening to me on my automated builds as well. I'm getting it to work by triggering it manually for now (through the build settings menu). Guess not all nodes have been deployed yet.

--Edit: not working by manually triggering it anymore :)

wilsontayar commented Aug 21, 2017

@gesellix @krambox The same thing is happening to me on my automated builds as well. I'm getting it to work by triggering it manually for now (through the build settings menu). Guess not all nodes have been deployed yet.

--Edit: not working by manually triggering it anymore :)

@pchico83

This comment has been minimized.

Show comment
Hide comment
@pchico83

pchico83 Aug 21, 2017

We have rollbacked the 17.06.1 release since some builds were failing due to the upgrade.
We are working on fixing this issue and release 17.06.1 tomorrow again.

pchico83 commented Aug 21, 2017

We have rollbacked the 17.06.1 release since some builds were failing due to the upgrade.
We are working on fixing this issue and release 17.06.1 tomorrow again.

@gesellix

This comment has been minimized.

Show comment
Hide comment
@gesellix

gesellix Aug 21, 2017

thanks for the quick feedback @pchico83

gesellix commented Aug 21, 2017

thanks for the quick feedback @pchico83

@pchico83

This comment has been minimized.

Show comment
Hide comment
@pchico83

pchico83 Aug 22, 2017

17.06.1 is running in prod again

pchico83 commented Aug 22, 2017

17.06.1 is running in prod again

@soulshake

This comment has been minimized.

Show comment
Hide comment
@soulshake

soulshake Aug 31, 2017

@pchico83 Did this get rolled back again? My builds just abruptly changed from:
Version: 17.06.1-ce [1]
to:
Version: 17.03.2-ee-5 [2]

soulshake commented Aug 31, 2017

@pchico83 Did this get rolled back again? My builds just abruptly changed from:
Version: 17.06.1-ce [1]
to:
Version: 17.03.2-ee-5 [2]

@caervs

This comment has been minimized.

Show comment
Hide comment
@caervs

caervs Aug 31, 2017

Collaborator

@soulshake we just had a brief regression that caused some builders to run older versions of Docker. Your builds should all be running on 17.06.1-ce again. Thanks for commenting and please let us know if you have any issues.

Collaborator

caervs commented Aug 31, 2017

@soulshake we just had a brief regression that caused some builders to run older versions of Docker. Your builds should all be running on 17.06.1-ce again. Thanks for commenting and please let us know if you have any issues.

@caervs caervs closed this Aug 31, 2017

@TheYorkshireDev

This comment has been minimized.

Show comment
Hide comment
@TheYorkshireDev

TheYorkshireDev Aug 31, 2017

@caervs I am having an issue since the upgrade, I am not sure if it is a regression since nobody is acknowledging my ticket #1145

TheYorkshireDev commented Aug 31, 2017

@caervs I am having an issue since the upgrade, I am not sure if it is a regression since nobody is acknowledging my ticket #1145

@zhucebuliaolongchuan

This comment has been minimized.

Show comment
Hide comment
@zhucebuliaolongchuan

zhucebuliaolongchuan Aug 29, 2018

Things works when I updated to version 18.06.1-ce.
Thanks~

zhucebuliaolongchuan commented Aug 29, 2018

Things works when I updated to version 18.06.1-ce.
Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment