Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Stage builds on docker hub #1039

Closed
captncraig opened this issue May 9, 2017 · 41 comments
Closed

Multi-Stage builds on docker hub #1039

captncraig opened this issue May 9, 2017 · 41 comments

Comments

@captncraig
Copy link

@captncraig captncraig commented May 9, 2017

In trying to run multi-stage builds in a docker hub automated build:

Error parsing reference: "golang:1.7.3 as builder" is not a valid repository/tag: invalid reference format

It looks like docker hub is not using the version of docker that supports this yet. Is there a timeline for when support will be availible?

@pkennedyr
Copy link
Contributor

@pkennedyr pkennedyr commented May 9, 2017

Thanks for the feedback. The Docker Hub and Docker Cloud automated build service will be adding support for multi-stage builds when this feature graduates to the stable channel (currently targeted for June as part of the 17.06 release).

For more information on the Docker time-based release schedule, please see: https://docs.docker.com/engine/installation/#time-based-release-schedule

@captncraig
Copy link
Author

@captncraig captncraig commented May 9, 2017

Thank you for the prompt feedback! Feel free to close this issue unless you'd rather leave it open until that release.

rakshazi pushed a commit to rakshazi/slim-skeleton that referenced this issue Jun 13, 2017
Nikita Chernyi
This reverts commit d2ccd7c.
@medyagh
Copy link

@medyagh medyagh commented Jun 14, 2017

@pkennedyr are we there there?
(aka is it there multistage on dockerhub yet?)

@captncraig
Copy link
Author

@captncraig captncraig commented Jun 14, 2017

@pkennedyr
Copy link
Contributor

@pkennedyr pkennedyr commented Jun 14, 2017

[UPDATE] Multi-stage builds are now available in Docker Cloud as part of the 5-30-2017 release:
https://forums.docker.com/t/docker-cloud-product-update-5-30-2017/32938

To take advantage of multi-stage builds (in Docker Cloud), select Edge (17.05.0-ce) as the Docker version of an automated repository.

We encourage you to try out Docker Cloud as this is where you will find support for this and many other autobuild features.

@medyagh
Copy link

@medyagh medyagh commented Jun 14, 2017

@pkennedyr is the multi stage build still scheduled for docker hub for this june ? or has that been cancelled and only available in docker cloud ?

laugimethods added a commit to Logimethods/docker-eureka that referenced this issue Jun 15, 2017
wongwill86 added a commit to wongwill86/air-tasks that referenced this issue Jun 15, 2017
apk added a commit to apk/c-utils that referenced this issue Jun 28, 2017
Now, if dockerhub had multi-stage builds I could
actually go ahead and use this in my images.

docker/hub-feedback#1039
@drasko
Copy link

@drasko drasko commented Jun 30, 2017

What's the conclusion - is Docker Hub getting multi-stage builds any time soon?

@pkennedyr
Copy link
Contributor

@pkennedyr pkennedyr commented Jun 30, 2017

[UPDATE to earlier post] Docker Hub will in fact support multi-stage builds when the automated build system is upgraded to 17.06.01 (target ETA July). We apologize for the confusion.

@milsonian
Copy link

@milsonian milsonian commented Jun 30, 2017

I'm a bit confused...

The biggest feature in 17.06 CE is that multi-stage builds, announced in April at DockerCon, have come to the stable release.

So is Hub not going to go to 17.06 at any point? Or are you pulling the feature from CE / will it be flagged / etc.?

@pkennedyr
Copy link
Contributor

@pkennedyr pkennedyr commented Jun 30, 2017

@milsonian Apologies for the confusion, with availability of multi-stage builds in 17.06, this feature will also be available in Docker Hub when the corresponding upgrade to 17.06 occurs (ETA July).

Note: Docker Cloud provides the ability to specify the Docker version (Stable or Edge) to use for an automated build, which enables access to the multi-stage build feature via the Edge channel today.

@milsonian
Copy link

@milsonian milsonian commented Jul 1, 2017

That's great, thanks for the clarification @pkennedyr!

@agc93
Copy link

@agc93 agc93 commented Jul 7, 2017

@pkennedyr Any update on when in July we can expect this feature on the Hub?

@pkennedyr
Copy link
Contributor

@pkennedyr pkennedyr commented Jul 7, 2017

Current ETA: late July

We are currently awaiting availability of 17.06.01 CE GA, which includes a bug fix for multi-stage builds. Once available, we will update the Automated Build system with this new version and multi-stage builds will be available in Docker Hub.

@gesellix
Copy link

@gesellix gesellix commented Aug 16, 2017

FYI: https://blog.docker.com/2017/08/docker-enterprise-edition-17-06/
The countdown to multi-stage builds being available on Docker Hub has started ;-)

@ph-One
Copy link

@ph-One ph-One commented Aug 18, 2017

17.06.1-ce has dropped. Anxiously awaiting to see all my broken [multi-stage] builds start to run.

@mghazizadeh
Copy link

@mghazizadeh mghazizadeh commented Aug 18, 2017

@ph-One team is working on the upgrade for builders, please stay tuned.

@cglewis
Copy link

@cglewis cglewis commented Aug 21, 2017

works on Docker Hub now for me.

@ibnesayeed
Copy link

@ibnesayeed ibnesayeed commented Aug 21, 2017

@cglewis: works on Docker Hub now for me.

I don't see any option to specify build-args #508 though.

@pkennedyr
Copy link
Contributor

@pkennedyr pkennedyr commented Aug 21, 2017

The Automated Build system has been updated with 17.06.01 CE, which enables multi-stage builds in Docker Hub.

@gesellix
Copy link

@gesellix gesellix commented Aug 21, 2017

It worked - but now it's reverted to Docker EE 17.03.1? See https://hub.docker.com/r/gesellix/wait-for/builds/btfvjxwqgzrhdhxxz55ilj6/ for an example.

@wilsontayar
Copy link

@wilsontayar wilsontayar commented Aug 21, 2017

@gesellix @krambox The same thing is happening to me on my automated builds as well. I'm getting it to work by triggering it manually for now (through the build settings menu). Guess not all nodes have been deployed yet.

--Edit: not working by manually triggering it anymore :)

@pchico83
Copy link

@pchico83 pchico83 commented Aug 21, 2017

We have rollbacked the 17.06.1 release since some builds were failing due to the upgrade.
We are working on fixing this issue and release 17.06.1 tomorrow again.

@gesellix
Copy link

@gesellix gesellix commented Aug 21, 2017

thanks for the quick feedback @pchico83

@pchico83
Copy link

@pchico83 pchico83 commented Aug 22, 2017

17.06.1 is running in prod again

@soulshake
Copy link

@soulshake soulshake commented Aug 31, 2017

@pchico83 Did this get rolled back again? My builds just abruptly changed from:
Version: 17.06.1-ce [1]
to:
Version: 17.03.2-ee-5 [2]

@caervs
Copy link

@caervs caervs commented Aug 31, 2017

@soulshake we just had a brief regression that caused some builders to run older versions of Docker. Your builds should all be running on 17.06.1-ce again. Thanks for commenting and please let us know if you have any issues.

@caervs caervs closed this Aug 31, 2017
@TheYorkshireDev
Copy link

@TheYorkshireDev TheYorkshireDev commented Aug 31, 2017

@caervs I am having an issue since the upgrade, I am not sure if it is a regression since nobody is acknowledging my ticket #1145

@zhucebuliaolongchuan
Copy link

@zhucebuliaolongchuan zhucebuliaolongchuan commented Aug 29, 2018

Things works when I updated to version 18.06.1-ce.
Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.