New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please integrate with GitLab.com #334

Open
thozza opened this Issue Sep 4, 2015 · 53 comments

Comments

Projects
None yet
@thozza

thozza commented Sep 4, 2015

Hi.

Since Gitlab already provides their hosted service for git repositories it would be great to have Docker Hub being integrated with Gitlab.com. Right now I have to mirror my repo with Dockerfile on Github or Bitbucket to be able to have automated builds.

@kencochrane

This comment has been minimized.

Contributor

kencochrane commented Sep 4, 2015

It is already in progress :)

@rrarunan rrarunan self-assigned this Sep 4, 2015

@thozza

This comment has been minimized.

thozza commented Sep 4, 2015

@kencochrane great! Thanks for the info. 😉

@anandchida

This comment has been minimized.

anandchida commented Nov 16, 2015

Do we have an ETA of this integration? Would love to move to hosted docker hub if gitlab support is available

@Jonjoe

This comment has been minimized.

Jonjoe commented Nov 28, 2015

+1 on giving an eta :) we have had to split our repos between bb and github. If we can get better GL integration it would be a dream come true <3

@kencochrane

This comment has been minimized.

Contributor

kencochrane commented Nov 28, 2015

Paging @mattsoldo so he can give an eta.

@joeldrapper

This comment has been minimized.

joeldrapper commented Dec 10, 2015

+1

@ejaz-ahmed

This comment has been minimized.

ejaz-ahmed commented Jan 8, 2016

Any update on this issue?

@pgrm

This comment has been minimized.

pgrm commented Jan 9, 2016

👍

1 similar comment
@jangorecki

This comment has been minimized.

jangorecki commented Jan 30, 2016

+1

@zwarag

This comment has been minimized.

zwarag commented Apr 27, 2016

@kencochrane Will this work with private hosted GitLabs to or only with the main one?
Or same question just different, do you plan on adding support for plain git like quay.io does?

@kencochrane

This comment has been minimized.

Contributor

kencochrane commented Apr 27, 2016

@pchico83 @dustinlacewell @caervs Can you answer those questions?

@pkennedyr

This comment has been minimized.

pkennedyr commented Apr 27, 2016

Thanks for the feedback! We are actively expanding our list of supported source providers on both Docker Hub and Docker Cloud and are targeting support for GitLab later in 2016.

Re: linking to a custom Git repository, we are happy to explore this option as well. Please upvote here to indicate interest in this feature, which will help us prioritize accordingly.

@jimador

This comment has been minimized.

jimador commented May 20, 2016

+1 It would be nice to have Gitlab integration, but a custom git solution might be more generic.

@thozza

This comment has been minimized.

thozza commented May 26, 2016

I guess we don't need Docker Hub for GitLab any more... https://about.gitlab.com/2016/05/23/gitlab-container-registry/ ;)

@c33s

This comment has been minimized.

c33s commented Aug 18, 2016

would prefer to use docker.io with gitlabs registry.
but dockerhub should also support generic git repos

the container-registry on gitlab doesn't really help, the main purpose for adding gitlab support for me is the automated build. i would love to only edit the dockerfile in my gitlab repo and the image gets automatically build by docker hub

@DrChr

This comment has been minimized.

DrChr commented Jan 10, 2017

Any update on this issue? (An earlier post mentioned later in 2016, and now we're in a very early 2017)

@czende

This comment has been minimized.

czende commented Jan 20, 2017

+1

1 similar comment
@andreasunterhuber

This comment has been minimized.

andreasunterhuber commented Apr 10, 2017

+1

@teodorescuserban

This comment has been minimized.

teodorescuserban commented Apr 14, 2017

+1
any update on this?

@hraban

This comment has been minimized.

hraban commented Apr 15, 2017

@c33s gitlab CI offers automatic building and uploading to the registry, much like dockerhub with github integration. it's done by putting the regular build and push commands in a CI dot-file in the repository instead of magically done by the registry through a push webhook, but the end result is the same: push to gitlab ---> automatically update the image in the registry.

see https://about.gitlab.com/2016/05/23/gitlab-container-registry/ ("Use with Gitlab CI" at the bottom)

I just tested this and it works fine.

Their sample .yml is not ideal, for clarity's sake here's mine:

build_image:
  image: docker:git
  services:
  - docker:dind
  script:
    - docker login -u gitlab-ci-token -p $CI_BUILD_TOKEN registry.gitlab.com
    - docker build -t registry.gitlab.com/my-group/my-project .
    - docker push registry.gitlab.com/my-group/my-project:latest
  only:
    - master
@Jonjoe

This comment has been minimized.

Jonjoe commented Apr 16, 2017

Thanks @hraban

@TheYorkshireDev

This comment has been minimized.

TheYorkshireDev commented Jul 12, 2017

@kencochrane Any update on this? As some of the previous commenters have mentioned this was opened in 2015 with the feature to be added in 2016. It is now 2017 and there is still no real news. It would be great to have gitlab as an option for been a linked account just like github and bitbucket is.

screen shot 2017-07-12 at 20 02 37

Does anyone know if this is still in the works?

@mileo

This comment has been minimized.

mileo commented Aug 15, 2017

up

@murbano83

This comment has been minimized.

murbano83 commented Sep 6, 2017

@kencochrane @pkennedyr @pchico83 no news on this?

@metalcamp

This comment has been minimized.

metalcamp commented Oct 20, 2017

Any news on this? For now I figured out a solution similar to @hraban, but complete integration would be great.

@RAYs3T

This comment has been minimized.

RAYs3T commented Jan 29, 2018

@kencochrane Anything new on this?

@teodorescuserban

This comment has been minimized.

teodorescuserban commented Jan 29, 2018

FYI my .gitlab-ci.yml (using a private gitlab runner) that will start building everytime a branch is changed.

variables:
  IMAGE_TAG: $CI_REGISTRY_IMAGE:$CI_COMMIT_REF_NAME

before_script:
  - docker login -u gitlab-ci-token -p $CI_JOB_TOKEN $CI_REGISTRY

build:
  stage: build
  script:
    - docker build -t $IMAGE_TAG .
    - docker push $IMAGE_TAG
@mckaygerhard

This comment has been minimized.

mckaygerhard commented Apr 11, 2018

docker cloud will no more since 21 may! ja! so in any case never was sense in "made inside other"!

so this issue has no importance any more!

@metalcamp

This comment has been minimized.

metalcamp commented Apr 11, 2018

@brendano86

This comment has been minimized.

brendano86 commented May 18, 2018

/giphy waiting

@lukad

This comment has been minimized.

lukad commented Jun 4, 2018

The missing GitLab integration is the only thing keeping me from moving all my projects to GitLab.
So +1 for this!

@teodorescuserban

This comment has been minimized.

teodorescuserban commented Jun 4, 2018

In the recent events around Microsoft acquiring GitHub I do hope this issue gets some more attention.

@bbashy

This comment has been minimized.

bbashy commented Jun 5, 2018

@teodorescuserban Tell me about it. Just moved everything and found out I can't change the repo to GitLab's... confusing. May just remove the project and build it in GitLab registry for myself instead of publicly.

@teodorescuserban

This comment has been minimized.

teodorescuserban commented Jun 5, 2018

@bbashy yep, thats what i did. (see above a very simple .gitlab-ci.yml)

@neechbear

This comment has been minimized.

neechbear commented Jun 5, 2018

Any progress on this? I imagine there will be many more people who are interested in this now since the GitHub announcement.

@revof11

This comment has been minimized.

revof11 commented Jul 2, 2018

I'm running with the .gitlab-ci.yml setup for now. I'm also waiting for CircleCI.com to add GitLab support for the rest of my projects. GitLab's CI is OK but it's just not wonderful-fantastic.

https://circleci.com/ideas/?idea=CCI-I-248

@FrankGiesecke

This comment has been minimized.

FrankGiesecke commented Jul 20, 2018

+1

1 similar comment
@createchange

This comment has been minimized.

createchange commented Jul 21, 2018

+1

@Queuecumber

This comment has been minimized.

Queuecumber commented Jul 29, 2018

@kencochrane 3 years later and no official statement, can you tell us anything?

@kencochrane

This comment has been minimized.

Contributor

kencochrane commented Jul 29, 2018

@Queuecumber sorry I don't work for Docker anymore, so I can't help you.

@Yajo

This comment has been minimized.

Yajo commented Jul 30, 2018

Gitlab ships a fully integrated docker registry, FYI.

@FrankGiesecke

This comment has been minimized.

FrankGiesecke commented Jul 30, 2018

@Yajo: That’s right, but for people who will host images on docker hub (using the automated build feature), it’s necessary to get a connector similar to GitHub.

@RAYs3T

This comment has been minimized.

RAYs3T commented Jul 31, 2018

@FrankGiesecke You can use GitLab's build-in CI to build and push the image. See this project for example: https://gitlab.com/RAYs3T/sourcemod-plugins-builder-ci/blob/master/.gitlab-ci.yml

You can also use it to push images to the offical registry.

@FrankGiesecke

This comment has been minimized.

FrankGiesecke commented Jul 31, 2018

@RAYs3T That’s also right. But using the built in CI of GitLab will cost runner time.
Automated builds on Docker Hub won’t.

Currently, the most image projects are hosted on GitHub using the automated build on Docker Hub.
Since Microsoft has taken over, many developers are looking for alternatives like GitLab. So a connector to GitLab will make sense for developers who want to migrate their projects.

@06kellyjac

This comment has been minimized.

06kellyjac commented Jul 31, 2018

Additionally, I don't know if this is fact but I've personally experienced automated builds ranking higher on Docker Hub searches than non-automated builds of similar or more downloads & stars.

@RAYs3T

This comment has been minimized.

RAYs3T commented Jul 31, 2018

@FrankGiesecke You will get 2000 free minutes per month on gitlab. Even for closed projects. And the quota is calculated also per group. So you won't use your personal quota if the project is member of a group.
And 2000 minutes / month should be enough?

It seems like the gitlab integration is not really wanted - we waiting for YEARS now, and nothing is happening. So we need some work-a-rounds for it...

@06kellyjac Ok, that one is quite important. So images which are not costing money (because the build-process is external) are treated worse then the pricey ones, running on the own infrastructure

@06kellyjac

This comment has been minimized.

06kellyjac commented Jul 31, 2018

@RAYs3T It's hard to find examples but if you search mutt on docker hub jessfraz/mutt is below cmoultrie/mutt

Name jessfraz/mutt cmoultrie/mutt
Automated No Yes
Stars 0 0
Pulls 187 138
Size 24MB 123MB
Last changed 5 days ago 1 year ago

There are a couple behind-the-scenes factors that could maybe impact it's position in the rankings:

  • More clicks on a docker image listing making it rank higher but lower pulls
  • More account views or total views on other docker files from the account?
  • Potential spam account???? - Jessie Frazelle's Docker Hub account is jess idk if it's a new account or another jessfraz but that was another thought I had

The best way to test this would probably be to create 2 new accounts & matching dockerfiles and play with staring and increasing the pull count of each docker image etc.

Note: I wouldn't be surprised if people could find cases showing the opposite. I think I have seen the opposite but it's more often not in my (limited) experience. Would be interesting to find out if that really impacts the search rankings.
Regardless of if it impacts search position, I generally prefer Auto builds myself as I can look at the docker image in the Hub or click the Repo link to have a look; I don't have to pull the docker image and investigate it on my machine to see if the contents match the repo, or build the image from the dockerfile myself, as I know it was actually built from the repo's dockerfile by docker. This preference for auto-builds would impact pull count and general popularity of any image even if the search ranking doesn't account for auto-builds.

@Yajo

This comment has been minimized.

Yajo commented Jul 31, 2018

Another option Gitlab has is to define a git mirror.

@06kellyjac

This comment has been minimized.

06kellyjac commented Jul 31, 2018

@Yajo yep, that's mentioned in the initial issue from 2015 😃 That's the approach I'm using but I'd rather not.

@Vadim-Zenin

This comment has been minimized.

Vadim-Zenin commented Oct 21, 2018

thozza opened this issue on 4 Sep 2015
After 3 (THREE YEARS) in 21 October 2018: no integration:

20181021-175439-hubdocker-integration-limits

Please integrate GitLab, because a lot of Open Source communities and members will move from GitHub after Microsoft acquisition. It has happened with Novell and Suse. We remember what happened with Nokia.

EU commission approves acquisition of GitHub by Microsoft

Goodbye GitHub. Hello GitLab!

@adawalli

This comment has been minimized.

adawalli commented Oct 22, 2018

Github servers going down today are a good example of why we need more options (e.g., gitlab) for linked accounts!

@iMilnb

This comment has been minimized.

iMilnb commented Nov 3, 2018

Mandatory +1
That politics smelly smell...

@teodorescuserban

This comment has been minimized.

teodorescuserban commented Nov 5, 2018

TBH I asked for it as well but then , when you actually move to GitLab, you may realise it's far easier to just use their docker repository as well (and also their CI stuff) than hang on travis and docker hub.

And if you have an org account on github, travis, docker hub, well, you just get a subscription for gitlab and thats it.

I don't see why docker would add gitlab integration at this point. Probably because they would want to keep the current dockerhub customers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment