Allow mounting custom volume directories #376

Closed
jmorganca opened this Issue Apr 15, 2015 · 67 comments

Comments

Projects
None yet
@jmorganca
Member

jmorganca commented Apr 15, 2015

Right now only volumes defined in Dockerfiles can be host-mounted via Kitematic. Users should have a way to host-mount into arbitrary folders in the container.

@jmorganca jmorganca added the feature label Apr 15, 2015

@kematzy

This comment has been minimized.

Show comment
Hide comment
@kematzy

kematzy Apr 16, 2015

+100

Also, some kind of documentation on how to convert a great docker container into a fully supported Kitematic container with custom volume addition, logs and previews would be great too.

kematzy commented Apr 16, 2015

+100

Also, some kind of documentation on how to convert a great docker container into a fully supported Kitematic container with custom volume addition, logs and previews would be great too.

@jmorganca

This comment has been minimized.

Show comment
Hide comment
@jmorganca

jmorganca Apr 16, 2015

Member

@kematzy great! Thanks for the note!

Member

jmorganca commented Apr 16, 2015

@kematzy great! Thanks for the note!

@gregorydickson

This comment has been minimized.

Show comment
Hide comment
@bauschan

This comment has been minimized.

Show comment
Hide comment

+1

@Blux

This comment has been minimized.

Show comment
Hide comment

Blux commented Apr 25, 2015

+1

@jb510

This comment has been minimized.

Show comment
Hide comment
@jb510

jb510 Apr 30, 2015

+1000 on @kematzy's "documentation on how to convert a great docker container into a fully supported Kitematic container with custom volume addition, logs and previews would be great too"

I've been banging my head into a lot of glass doors today trying to figure that out on my own.

The only container that seems to work with mounted volumes is kitematic/hello-world-nginx and I can't even find the source and how how it does it.

Every other container with volumes breaks as soon as I enable them.

jb510 commented Apr 30, 2015

+1000 on @kematzy's "documentation on how to convert a great docker container into a fully supported Kitematic container with custom volume addition, logs and previews would be great too"

I've been banging my head into a lot of glass doors today trying to figure that out on my own.

The only container that seems to work with mounted volumes is kitematic/hello-world-nginx and I can't even find the source and how how it does it.

Every other container with volumes breaks as soon as I enable them.

@jmorganca

This comment has been minimized.

Show comment
Hide comment
@jmorganca

jmorganca Apr 30, 2015

Member

@jb510 really sorry to hear that! It's mostly from the Dockerfile. The summary:

Volumes: Make sure there's a VOLUME directive in the Dockerfile
Ports: Make sure there's an EXPOSE directive in the Dockerfile
Environment variables: Use ENV directives in the Dockerfile

and we'll post a doc article on the website (kitematic.com/docs) soon

Member

jmorganca commented Apr 30, 2015

@jb510 really sorry to hear that! It's mostly from the Dockerfile. The summary:

Volumes: Make sure there's a VOLUME directive in the Dockerfile
Ports: Make sure there's an EXPOSE directive in the Dockerfile
Environment variables: Use ENV directives in the Dockerfile

and we'll post a doc article on the website (kitematic.com/docs) soon

@jb510

This comment has been minimized.

Show comment
Hide comment
@jb510

jb510 Apr 30, 2015

@jeffdm Oh goodness don't be sorry! Kitematic is freaking amazing... All sorts of possibilities are swirling through my head.

One question. Where do I find the Dockerfile for kitematic/hello-world-nginx ? I'd like to read/understand it and I can't find it.

jb510 commented Apr 30, 2015

@jeffdm Oh goodness don't be sorry! Kitematic is freaking amazing... All sorts of possibilities are swirling through my head.

One question. Where do I find the Dockerfile for kitematic/hello-world-nginx ? I'd like to read/understand it and I can't find it.

@jmorganca

This comment has been minimized.

Show comment
Hide comment
@jmorganca

jmorganca Apr 30, 2015

Member

@jb510 here https://github.com/kitematic/html although we had to squash the image for faster download.

@mchiang0610 it may be a good idea to make this an automated build instead for the Dockerfile reference

Member

jmorganca commented Apr 30, 2015

@jb510 here https://github.com/kitematic/html although we had to squash the image for faster download.

@mchiang0610 it may be a good idea to make this an automated build instead for the Dockerfile reference

@jb510

This comment has been minimized.

Show comment
Hide comment
@jb510

jb510 Apr 30, 2015

TY! Exactly what I was looking for!

jb510 commented Apr 30, 2015

TY! Exactly what I was looking for!

@ajermakovics

This comment has been minimized.

Show comment
Hide comment

+1

@nym

This comment has been minimized.

Show comment
Hide comment

nym commented May 12, 2015

+1

@mchiang0610

This comment has been minimized.

Show comment
Hide comment
@mchiang0610

mchiang0610 May 12, 2015

Contributor

This is definitely something that should be on the roadmap for Kitematic. Is anyone willing to help us work on this as we prioritize on the Windows version of Kitematic in the meantime? @kematzy @ajermakovics @jb510 @nym

Would love to hear thoughts on how it should be implemented.

Contributor

mchiang0610 commented May 12, 2015

This is definitely something that should be on the roadmap for Kitematic. Is anyone willing to help us work on this as we prioritize on the Windows version of Kitematic in the meantime? @kematzy @ajermakovics @jb510 @nym

Would love to hear thoughts on how it should be implemented.

@alexj

This comment has been minimized.

Show comment
Hide comment
@alexj

alexj May 16, 2015

Not to pile on, but I'll add a +1. I've been excited to try Docker via Kitematic, but not being able to define a volume is a hard blocker for me. I've banged my head a few times now trying to set up various Wordpress containers, but couldn't find where the files could be edited. Luckily, I found this thread. I'm excited about Kitematic, as I think I could use it to ease how I work on side projects (PHP, Python, and eventually Node).

Sadly, I don't think there's much I can contribute to move this forward, outside of explaining my expectations as a user:

  • When I load a new container, it would ideally have a volume set up with access to that container's filesystem.
  • For specific containers, like one devoted to WordPress, I'd love it if Kitematic provided an easy way to go straight to that software's directory root
  • I want to be able to change the Volume's mapping of the Docker Folder - > Mac Folder, as I can with hello-world-nginx. I should be able to do this whether or not the creator of the Creator specifically enabled it.

I'm new to Docker, so I may be asking for too much, but I thought it worth documenting.

Thanks, and keep up the great work!

alexj commented May 16, 2015

Not to pile on, but I'll add a +1. I've been excited to try Docker via Kitematic, but not being able to define a volume is a hard blocker for me. I've banged my head a few times now trying to set up various Wordpress containers, but couldn't find where the files could be edited. Luckily, I found this thread. I'm excited about Kitematic, as I think I could use it to ease how I work on side projects (PHP, Python, and eventually Node).

Sadly, I don't think there's much I can contribute to move this forward, outside of explaining my expectations as a user:

  • When I load a new container, it would ideally have a volume set up with access to that container's filesystem.
  • For specific containers, like one devoted to WordPress, I'd love it if Kitematic provided an easy way to go straight to that software's directory root
  • I want to be able to change the Volume's mapping of the Docker Folder - > Mac Folder, as I can with hello-world-nginx. I should be able to do this whether or not the creator of the Creator specifically enabled it.

I'm new to Docker, so I may be asking for too much, but I thought it worth documenting.

Thanks, and keep up the great work!

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jun 21, 2015

Contributor

+1111 !

Contributor

zedtux commented Jun 21, 2015

+1111 !

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jun 21, 2015

Contributor

I have a first version of this feature working (adding new volume, setting the folder, see the volume in the container and read/write files from container and from host).

There are still some updates to do especially when removing volumes.

It doesn't really make sense I'm publishing my code for now as I'm branching from my Linux fork. As soon as done, in the case the Linux portage is not merged I will do another branch originating from master and test on OSX.

Here is how it looks like:

screenshot from 2015-06-21 19 31 05

Contributor

zedtux commented Jun 21, 2015

I have a first version of this feature working (adding new volume, setting the folder, see the volume in the container and read/write files from container and from host).

There are still some updates to do especially when removing volumes.

It doesn't really make sense I'm publishing my code for now as I'm branching from my Linux fork. As soon as done, in the case the Linux portage is not merged I will do another branch originating from master and test on OSX.

Here is how it looks like:

screenshot from 2015-06-21 19 31 05

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jun 21, 2015

Contributor

I have solved the refresh issue with the LOCAL FOLDER when using 'CHANGE' and 'REMOVE' buttons.

Contributor

zedtux commented Jun 21, 2015

I have solved the refresh issue with the LOCAL FOLDER when using 'CHANGE' and 'REMOVE' buttons.

@affogato

This comment has been minimized.

Show comment
Hide comment
@affogato

affogato Jun 23, 2015

Why is this not possible with some containers e.g. Tomcat ?

Why is this not possible with some containers e.g. Tomcat ?

@pik0

This comment has been minimized.

Show comment
Hide comment
@pik0

pik0 Jun 24, 2015

How do I add a volume in the Configure Volumes panel? I've downloaded the nginx:latest (not hello world) and the panel shows the mount, but no plus (+). Maybe the docker file is read only or is there some other setting I need to do to to make changes?

Also, where are the docker files stored that I might be able to start making my own.

Sorry for the RTFM questions, but I can't seem to find anything more than basic documentation online...

pik0 commented Jun 24, 2015

How do I add a volume in the Configure Volumes panel? I've downloaded the nginx:latest (not hello world) and the panel shows the mount, but no plus (+). Maybe the docker file is read only or is there some other setting I need to do to to make changes?

Also, where are the docker files stored that I might be able to start making my own.

Sorry for the RTFM questions, but I can't seem to find anything more than basic documentation online...

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jun 25, 2015

Contributor

@affogato sorry .. what ?

@pik0 have you cloned my repository and then checked out the branch linux/features/add-volumes (BTW are you running Kitematic on Linux as the Linux portage is not yet in master and I need to use it in order to contribute to the project so my branch is Linux only for now ...)

Contributor

zedtux commented Jun 25, 2015

@affogato sorry .. what ?

@pik0 have you cloned my repository and then checked out the branch linux/features/add-volumes (BTW are you running Kitematic on Linux as the Linux portage is not yet in master and I need to use it in order to contribute to the project so my branch is Linux only for now ...)

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jun 25, 2015

Contributor

I have opened a pull request with the final implementation. All the details are in the pull request and the pull request has been done without the Linux support so that you can test it @jeffdm, @kematzy, @gregorydickson, @bauschan, @Blux, @jb510, @ajermakovics, @nym, @mchiang0610, @alexj, @affogato and @pik0.

Feel free to send me your feedbacks ! :)

Contributor

zedtux commented Jun 25, 2015

I have opened a pull request with the final implementation. All the details are in the pull request and the pull request has been done without the Linux support so that you can test it @jeffdm, @kematzy, @gregorydickson, @bauschan, @Blux, @jb510, @ajermakovics, @nym, @mchiang0610, @alexj, @affogato and @pik0.

Feel free to send me your feedbacks ! :)

kyleskrinak added a commit to kyleskrinak/drupal that referenced this issue Jun 29, 2015

@affogato

This comment has been minimized.

Show comment
Hide comment
@affogato

affogato Jun 30, 2015

@zedtux To elaborate, for most of the containers that I want to use in Kitematic (e.g. official Rails, official Tomcat), it is not possible to set the Volumes or Ports parameters in the Settings tabs.
It is easy to set them on the command line with boot2docker, but I'd much rather use Kitematic.

@zedtux To elaborate, for most of the containers that I want to use in Kitematic (e.g. official Rails, official Tomcat), it is not possible to set the Volumes or Ports parameters in the Settings tabs.
It is easy to set them on the command line with boot2docker, but I'd much rather use Kitematic.

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jul 1, 2015

Contributor

Sorry @affogato, what do you mean ?

Using my fork allows you to add/remove Volumes (not ports but it the next thing I'll do). Now regarding the easy way of doing it, just tell me your idea if you have one and I can change the code ;)

Contributor

zedtux commented Jul 1, 2015

Sorry @affogato, what do you mean ?

Using my fork allows you to add/remove Volumes (not ports but it the next thing I'll do). Now regarding the easy way of doing it, just tell me your idea if you have one and I can change the code ;)

@jmorganca

This comment has been minimized.

Show comment
Hide comment
@jmorganca

jmorganca Jul 1, 2015

Member

Fantastic! Sorry for the radio silence. Will take a look at the PR after Linux support.

Member

jmorganca commented Jul 1, 2015

Fantastic! Sorry for the radio silence. Will take a look at the PR after Linux support.

@pik0

This comment has been minimized.

Show comment
Hide comment
@pik0

pik0 Jul 2, 2015

I'm using Kitematic on Mac OS Yosemite. Will the container auto update? Or do I need to add it anew to get the latest Dockerfile?

pik0 commented Jul 2, 2015

I'm using Kitematic on Mac OS Yosemite. Will the container auto update? Or do I need to add it anew to get the latest Dockerfile?

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jul 2, 2015

Contributor

@pik0 you don't need to update anything. Until this code is merge in the Git official repository, you have to clone my repository using git and then checkout the branch features/volumes-management. Here running make and npm start should make Kitematic popping up with the editable Volumes.

Contributor

zedtux commented Jul 2, 2015

@pik0 you don't need to update anything. Until this code is merge in the Git official repository, you have to clone my repository using git and then checkout the branch features/volumes-management. Here running make and npm start should make Kitematic popping up with the editable Volumes.

@pik0

This comment has been minimized.

Show comment
Hide comment
@pik0

pik0 Jul 2, 2015

Okay, i’ll give that a shot. Fortunately, we’re still in the evaluation phase for Docker so it’s not (yet) mission critical… :)

Pik0

On Jul 2, 2015, at 1:21 PM, Guillaume Hain notifications@github.com wrote:

@pik0 https://github.com/pik0 you don't need to update anything. Until this code is merge in the Git official repository, you have to clone my repository using git and then checkout the branch features/volumes-management. Here running make and npm start should make Kitematic popping up with the editable Volumes.


Reply to this email directly or view it on GitHub #376 (comment).

pik0 commented Jul 2, 2015

Okay, i’ll give that a shot. Fortunately, we’re still in the evaluation phase for Docker so it’s not (yet) mission critical… :)

Pik0

On Jul 2, 2015, at 1:21 PM, Guillaume Hain notifications@github.com wrote:

@pik0 https://github.com/pik0 you don't need to update anything. Until this code is merge in the Git official repository, you have to clone my repository using git and then checkout the branch features/volumes-management. Here running make and npm start should make Kitematic popping up with the editable Volumes.


Reply to this email directly or view it on GitHub #376 (comment).

@ericelliott

This comment has been minimized.

Show comment
Hide comment

+1

@ericelliott ericelliott referenced this issue in jshomes/JSHomes-Platform Jul 30, 2015

Merged

Vagrant environment with Docker-compose orchestration #38

@Manfred73

This comment has been minimized.

Show comment
Hide comment
@Manfred73

Manfred73 Aug 26, 2015

I have a mongodb container created with kitematic. It sets the ports and access url which I can use to access it, but the volume is not set. When I change the volume to a location under my user directory, the port and access url disappear.

I have a mongodb container created with kitematic. It sets the ports and access url which I can use to access it, but the volume is not set. When I change the volume to a location under my user directory, the port and access url disappear.

@marcelorodrigo

This comment has been minimized.

Show comment
Hide comment

+1, please

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Nov 17, 2015

Contributor

@marcelorodrigo as soon as my Pull Request for the Linux support is merged, I will refresh this PR and update it.

Contributor

zedtux commented Nov 17, 2015

@marcelorodrigo as soon as my Pull Request for the Linux support is merged, I will refresh this PR and update it.

@marcelorodrigo

This comment has been minimized.

Show comment
Hide comment

@zedtux great work ;)

@RVN-BR

This comment has been minimized.

Show comment
Hide comment
@RVN-BR

RVN-BR Nov 24, 2015

Any idea why th PRs from Jun still havent made there way in? Adding custom mountpoints should be a natural thing IMO.... just like it isnt limited when running docker CLI, I dont see why it should me limited in Kitematic?

RVN-BR commented Nov 24, 2015

Any idea why th PRs from Jun still havent made there way in? Adding custom mountpoints should be a natural thing IMO.... just like it isnt limited when running docker CLI, I dont see why it should me limited in Kitematic?

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Nov 24, 2015

Contributor

@RVN-BR basically I'm finishing first my PR on the linux support then I'll finish this PR. It shouldn't be too much to do to finish it so it should be merged very soon

Contributor

zedtux commented Nov 24, 2015

@RVN-BR basically I'm finishing first my PR on the linux support then I'll finish this PR. It shouldn't be too much to do to finish it so it should be merged very soon

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Nov 24, 2015

Contributor

@zedtux There's a similar PR in place, which seems to also remove some of the Virtualbox quirkiness available here: #1202

Just a thought.

Contributor

FrenchBen commented Nov 24, 2015

@zedtux There's a similar PR in place, which seems to also remove some of the Virtualbox quirkiness available here: #1202

Just a thought.

@tiptronic

This comment has been minimized.

Show comment
Hide comment
@tiptronic

tiptronic Jan 16, 2016

Any news on this?

Any news on this?

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jan 16, 2016

Contributor

I tried to merge master but the code changed too much, especially the usage of props instread of state break completely my code.
I tried anyway to make it working quickly but it will take some time ... It's always the same story when waiting before to merge PR :-)
Code is moving too fast.

Anyway, I'll do my best to get back on track with this feature.

Contributor

zedtux commented Jan 16, 2016

I tried to merge master but the code changed too much, especially the usage of props instread of state break completely my code.
I tried anyway to make it working quickly but it will take some time ... It's always the same story when waiting before to merge PR :-)
Code is moving too fast.

Anyway, I'll do my best to get back on track with this feature.

@tiptronic

This comment has been minimized.

Show comment
Hide comment
@tiptronic

tiptronic Jan 16, 2016

That would be great! This would make Kitematic 100x more useful than it is already!

That would be great! This would make Kitematic 100x more useful than it is already!

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Jan 18, 2016

Contributor

As mentioned before, there's a different PR now open for this, see: #376 (comment)

@zedtux's PR was closed in favor of 1202

Contributor

FrenchBen commented Jan 18, 2016

As mentioned before, there's a different PR now open for this, see: #376 (comment)

@zedtux's PR was closed in favor of 1202

@tiptronic

This comment has been minimized.

Show comment
Hide comment
@tiptronic

tiptronic Jan 19, 2016

Hm... if I'm not mistaken, I'm on #376 ;)

Hm... if I'm not mistaken, I'm on #376 ;)

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Jan 19, 2016

Contributor

Yup just mentioning that the proper PR for this feature was provided in the comment as linked :)

Contributor

FrenchBen commented Jan 19, 2016

Yup just mentioning that the proper PR for this feature was provided in the comment as linked :)

@tiptronic

This comment has been minimized.

Show comment
Hide comment
@tiptronic

tiptronic Jan 19, 2016

Ah - ok... didn't get it, since there was no link to 1202 (and I just clicked the link) ;)

Ah - ok... didn't get it, since there was no link to 1202 (and I just clicked the link) ;)

jasonm added a commit to minervaproject/docker-graphite-statsd that referenced this issue Jan 20, 2016

@syardumi

This comment has been minimized.

Show comment
Hide comment
@syardumi

syardumi Feb 24, 2016

I built @alexandrev's PR for issue 1202 on his branch pr-1192, but I didn't see the functionality mentioned in this issue. Will he be including the custom volumes feature (add/remove/etc.) in this PR?

I built @alexandrev's PR for issue 1202 on his branch pr-1192, but I didn't see the functionality mentioned in this issue. Will he be including the custom volumes feature (add/remove/etc.) in this PR?

@alexandrev

This comment has been minimized.

Show comment
Hide comment
@alexandrev

alexandrev Feb 24, 2016

Contributor

The code of this PR is here: #1202 and you can see that other people could build and test the code. If you have any troubles trying to get it built, please, let me know

Contributor

alexandrev commented Feb 24, 2016

The code of this PR is here: #1202 and you can see that other people could build and test the code. If you have any troubles trying to get it built, please, let me know

@syardumi

This comment has been minimized.

Show comment
Hide comment
@syardumi

syardumi Feb 24, 2016

Thanks Alex. I did find the code and built it with no problems. But, I don't see the "add/remove custom volumes" feature in it. Am I missing something?

Thanks Alex. I did find the code and built it with no problems. But, I don't see the "add/remove custom volumes" feature in it. Am I missing something?

@alexandrev

This comment has been minimized.

Show comment
Hide comment
@alexandrev

alexandrev Feb 24, 2016

Contributor

No, you cannot add a new volume, you can map a volume to a custom folder.

Contributor

alexandrev commented Feb 24, 2016

No, you cannot add a new volume, you can map a volume to a custom folder.

@syardumi

This comment has been minimized.

Show comment
Hide comment
@syardumi

syardumi Feb 25, 2016

@zedtux Is it OK if I take over on this issue? I should be able to adapt your code fairly easily.

All - this issue request is very different than issue #1202

@zedtux Is it OK if I take over on this issue? I should be able to adapt your code fairly easily.

All - this issue request is very different than issue #1202

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Feb 26, 2016

Contributor

@syardumi I haven't finished my PR as @FrenchBen selected another one which was apparently covering the need, otherwise I would have completed it.

Now if, as you previously said, it's not really the same, you can take over of course, but it's then too bad for me :)

Contributor

zedtux commented Feb 26, 2016

@syardumi I haven't finished my PR as @FrenchBen selected another one which was apparently covering the need, otherwise I would have completed it.

Now if, as you previously said, it's not really the same, you can take over of course, but it's then too bad for me :)

@syardumi

This comment has been minimized.

Show comment
Hide comment
@syardumi

syardumi Feb 26, 2016

Yea, and that PR has been closed in favor of 1202 also, but the functionality talked about in both this one and 722 are not included. @zedtux don't let me stop you from completing this request. My intention was not to take away a project you enjoy. I simply downloaded Kitematic, saw the feature missing - that would put Kitematic on par with Tutum for this feature - and decided to investigate. That lead me to here and to 1202 and now to 722 before noticing that it all got lost in the shuffle. Thanks for all your hard work you've done to get it started too!

Yea, and that PR has been closed in favor of 1202 also, but the functionality talked about in both this one and 722 are not included. @zedtux don't let me stop you from completing this request. My intention was not to take away a project you enjoy. I simply downloaded Kitematic, saw the feature missing - that would put Kitematic on par with Tutum for this feature - and decided to investigate. That lead me to here and to 1202 and now to 722 before noticing that it all got lost in the shuffle. Thanks for all your hard work you've done to get it started too!

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Feb 26, 2016

Contributor

Thank you @syardumi. I'm quite busy on other stuff so you can take my work and make it working with the current master if you'd like to.

Contributor

zedtux commented Feb 26, 2016

Thank you @syardumi. I'm quite busy on other stuff so you can take my work and make it working with the current master if you'd like to.

@alexandrev

This comment has been minimized.

Show comment
Hide comment
@alexandrev

alexandrev Feb 26, 2016

Contributor

Could you explain or even drafted the feature that you are missing? How
should it work? A way to add or remove more volumes than the ones specified
on the dockerfile? Previous the first time you create the container or in
the container settings for new configurations?

We can add it to the PR 1202 so you don't miss anything but I need to know
exactly the requirements to deliver it.

Thanks in advance.

On Fri, Feb 26, 2016, 15:29 syardumi notifications@github.com wrote:

Yea, and that PR has been closed in favor of 1202 also, but the
functionality talked about in both this one and 722 are not included.
@zedtux https://github.com/zedtux don't let me stop you from completing
this request. My intention was not to take away a project you enjoy. I
simply downloaded Kitematic, saw the feature missing - that would put
Kitematic on par with Tutum for this feature - and decided to investigate.
That lead me to here and to 1202 and now to 722 before noticing that it all
got lost in the shuffle. Thanks for all your hard work you've done to get
it started too!


Reply to this email directly or view it on GitHub
#376 (comment).

Contributor

alexandrev commented Feb 26, 2016

Could you explain or even drafted the feature that you are missing? How
should it work? A way to add or remove more volumes than the ones specified
on the dockerfile? Previous the first time you create the container or in
the container settings for new configurations?

We can add it to the PR 1202 so you don't miss anything but I need to know
exactly the requirements to deliver it.

Thanks in advance.

On Fri, Feb 26, 2016, 15:29 syardumi notifications@github.com wrote:

Yea, and that PR has been closed in favor of 1202 also, but the
functionality talked about in both this one and 722 are not included.
@zedtux https://github.com/zedtux don't let me stop you from completing
this request. My intention was not to take away a project you enjoy. I
simply downloaded Kitematic, saw the feature missing - that would put
Kitematic on par with Tutum for this feature - and decided to investigate.
That lead me to here and to 1202 and now to 722 before noticing that it all
got lost in the shuffle. Thanks for all your hard work you've done to get
it started too!


Reply to this email directly or view it on GitHub
#376 (comment).

@syardumi

This comment has been minimized.

Show comment
Hide comment
@syardumi

syardumi Feb 26, 2016

Alex, the idea would be to customize any and all mount points after the container is added to Docker. That said, I worked out a possible solution already via this branch: https://github.com/syardumi/kitematic/tree/PR-376

It's not exactly like @zedtux 's solution, but it's pretty close.

screen shot 2016-02-26 at 1 40 36 pm

screen shot 2016-02-26 at 1 41 01 pm

screen shot 2016-02-26 at 1 41 15 pm

Alex, the idea would be to customize any and all mount points after the container is added to Docker. That said, I worked out a possible solution already via this branch: https://github.com/syardumi/kitematic/tree/PR-376

It's not exactly like @zedtux 's solution, but it's pretty close.

screen shot 2016-02-26 at 1 40 36 pm

screen shot 2016-02-26 at 1 41 01 pm

screen shot 2016-02-26 at 1 41 15 pm

@alexandrev

This comment has been minimized.

Show comment
Hide comment
@alexandrev

alexandrev Feb 26, 2016

Contributor

Ok, if you like I could take a look and try it to merge it with the current
version of pull request 1202

On Fri, Feb 26, 2016, 19:34 syardumi notifications@github.com wrote:

Alex, the idea would be to customize any and all mount points after the
container is added to Docker. That said, I worked out a possible solution
already via this branch: https://github.com/syardumi/kitematic/tree/PR-376

It's not exactly like @zedtux https://github.com/zedtux 's solution,
but it's pretty close.


Reply to this email directly or view it on GitHub
#376 (comment).

Contributor

alexandrev commented Feb 26, 2016

Ok, if you like I could take a look and try it to merge it with the current
version of pull request 1202

On Fri, Feb 26, 2016, 19:34 syardumi notifications@github.com wrote:

Alex, the idea would be to customize any and all mount points after the
container is added to Docker. That said, I worked out a possible solution
already via this branch: https://github.com/syardumi/kitematic/tree/PR-376

It's not exactly like @zedtux https://github.com/zedtux 's solution,
but it's pretty close.


Reply to this email directly or view it on GitHub
#376 (comment).

@syardumi

This comment has been minimized.

Show comment
Hide comment
@syardumi

syardumi Feb 26, 2016

Yea, please do. However, I've only tested on Mac OS X and not extensively, so know that it may need some cleaning up.

Yea, please do. However, I've only tested on Mac OS X and not extensively, so know that it may need some cleaning up.

@chenasraf

This comment has been minimized.

Show comment
Hide comment
@chenasraf

chenasraf Jun 7, 2016

+1. Any news on this?

+1. Any news on this?

@syardumi

This comment has been minimized.

Show comment
Hide comment
@syardumi

syardumi Jun 7, 2016

@alexandrev did you ever merge my branch into PR 1202?

syardumi commented Jun 7, 2016

@alexandrev did you ever merge my branch into PR 1202?

@ShashankaNataraj

This comment has been minimized.

Show comment
Hide comment
@ShashankaNataraj

ShashankaNataraj Jul 5, 2016

OK, I just went to the volumes tab under settings and dont see a plus / add button. Not sure why this is in the downloadable version if it isnt functional yet...

OK, I just went to the volumes tab under settings and dont see a plus / add button. Not sure why this is in the downloadable version if it isnt functional yet...

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Jul 7, 2016

Contributor

@ShashankaNataraj because the developers that helped work on this issue have yet to rebase their code.
Feel free to help them out.

Contributor

FrenchBen commented Jul 7, 2016

@ShashankaNataraj because the developers that helped work on this issue have yet to rebase their code.
Feel free to help them out.

@karneaud

This comment has been minimized.

Show comment
Hide comment

+1000

@FuriouslyCurious

This comment has been minimized.

Show comment
Hide comment
@FuriouslyCurious

FuriouslyCurious Aug 26, 2016

@syardumi Excellent solution!

@alexandrev Alex, please merge his solution in #1202 - this is a very important feature that lot of people are craving for.

@syardumi Excellent solution!

@alexandrev Alex, please merge his solution in #1202 - this is a very important feature that lot of people are craving for.

@jbownzino

This comment has been minimized.

Show comment
Hide comment

+1

@karneaud

This comment has been minimized.

Show comment
Hide comment
@karneaud

karneaud Aug 30, 2016

you guys should take a look at docker-sync

you guys should take a look at docker-sync

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Aug 31, 2016

Contributor

@karneaud this has been done in Docker for Mac/Windows.

Contributor

FrenchBen commented Aug 31, 2016

@karneaud this has been done in Docker for Mac/Windows.

@midlettuce

This comment has been minimized.

Show comment
Hide comment
@midlettuce

midlettuce Sep 27, 2016

can't add volumes, still.

starting up with -v will create a volume which is half editable in current UI.

docker run -v [local_folder]:[remote_folder] -p 8888:8888 [image]

can't add volumes, still.

starting up with -v will create a volume which is half editable in current UI.

docker run -v [local_folder]:[remote_folder] -p 8888:8888 [image]

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Sep 28, 2016

Contributor

@midlettuce feel free to open up an issue with the image owner for not exposing the proper volumes.

Contributor

FrenchBen commented Sep 28, 2016

@midlettuce feel free to open up an issue with the image owner for not exposing the proper volumes.

@raphaklaus

This comment has been minimized.

Show comment
Hide comment
@raphaklaus

raphaklaus Oct 7, 2016

In 0.12.0 this issue seems to be not implemented under Windows.

In 0.12.0 this issue seems to be not implemented under Windows.

@jamesmanning

This comment has been minimized.

Show comment
Hide comment
@jamesmanning

jamesmanning Oct 24, 2016

@FrenchBen WRT "this has been done in Docker for Mac/Windows." does "this" mean Kitematic should allow adding volumes to containers even for volumes not defined in the Dockerfile? I installed Docker for Windows 2.0.7135 on October 12 (Kitematic/version says v0.35.4) but don't see any UI under Settings -> Volumes for adding a volume. Am I looking in the wrong place?

The files under Docker/Kitematic appears to have been built on July 27, so is the issue that the changes have been made, but a new version is needed that incorporates the changes? I tried the beta channel as well, but the Kitematic build there seems to be the same as in the stable channel AFAICT.

Thanks!

jamesmanning commented Oct 24, 2016

@FrenchBen WRT "this has been done in Docker for Mac/Windows." does "this" mean Kitematic should allow adding volumes to containers even for volumes not defined in the Dockerfile? I installed Docker for Windows 2.0.7135 on October 12 (Kitematic/version says v0.35.4) but don't see any UI under Settings -> Volumes for adding a volume. Am I looking in the wrong place?

The files under Docker/Kitematic appears to have been built on July 27, so is the issue that the changes have been made, but a new version is needed that incorporates the changes? I tried the beta channel as well, but the Kitematic build there seems to be the same as in the stable channel AFAICT.

Thanks!

@jthomas jthomas referenced this issue in node-red/node-red-docker Nov 11, 2016

Closed

Please add the VOLUME tag back in to the dockerfile! #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment