Allow mounting custom volume directories #722

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
3 participants
@zedtux
Contributor

zedtux commented Jun 25, 2015

This pull request solve the issue #376.

This pull request updates the "Volumes" sub tab panel of the "Settings" container tab with a line to add new volumes:

screenshot from 2015-06-25 20 51 02

Writing a path, clicking the plus and then 'Save' will update the container so that a new folder is available but empty.

screenshot from 2015-06-25 20 53 15

Then selecting a local folder using the 'CHANGE' button will now refresh correctly the UI (before it was refresh only when going somewhere else and then back to the tab) and also will Bind the local path to the Docker path.

screenshot from 2015-06-25 20 55 00

Now you can click the 'REMOVE' button to unlink the local folder (not new) or you can use the X button to remove completely the volume, which will re-create immediately the container (also there were a bug here with the Binds attribute of the Docker server API. It is now embedded in the HostConfig attribute while Kitematic was setting the Binds attribute at the root of the JSON).

screenshot from 2015-06-25 20 57 33

Last but not least, the 'RESET' button allow the user to revert the changes until he clicks the 'SAVE' button.
So let say the user add some volumes and use the 'CHANGE' button to link the local folder to the docker folder (clicking the 'EXEC' icon and list the folders in the terminal will show the new folders) but then he wants to rollback everything as it was before, he can click the 'RESET' button which will unlink and remove the folders automatically.

zedtux added some commits Jun 21, 2015

@TeckniX

This comment has been minimized.

Show comment
Hide comment
@TeckniX

TeckniX Jul 2, 2015

Contributor

@zedtux Did you get a chance to clean-up some of the code. I'd really like to give this one more review before the core maintainers get to it :)

Contributor

TeckniX commented Jul 2, 2015

@zedtux Did you get a chance to clean-up some of the code. I'd really like to give this one more review before the core maintainers get to it :)

@TeckniX

This comment has been minimized.

Show comment
Hide comment
@TeckniX

TeckniX Jul 2, 2015

Contributor

Some additional UX feedback/suggestions:

  • Initial load of the 'Volumes' tab did not show the Dockerfile exposed volumes
    init-volumes
    vs current kitematic
    volumes
  • The 'empty' folder entry cannot have its local folder modified until you've clicked the
  • Perhaps the Local 'Change' button should auto-fill the Docker Folder input if one hasn't been defined (last folder in the path?)
Contributor

TeckniX commented Jul 2, 2015

Some additional UX feedback/suggestions:

  • Initial load of the 'Volumes' tab did not show the Dockerfile exposed volumes
    init-volumes
    vs current kitematic
    volumes
  • The 'empty' folder entry cannot have its local folder modified until you've clicked the
  • Perhaps the Local 'Change' button should auto-fill the Docker Folder input if one hasn't been defined (last folder in the path?)
@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jul 2, 2015

Contributor

@TeckniX I did the code review you told me. Do you see anything else ?

Contributor

zedtux commented Jul 2, 2015

@TeckniX I did the code review you told me. Do you see anything else ?

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jul 2, 2015

Contributor

Initial load of the 'Volumes' tab did not show the Dockerfile exposed volumes

This is a bug in Kitematic. I have already noticed it but didn't fixed it.
Let say it's the first time you run Kitematic, all is fine. You create container(s) and work with. You will not have this issue.
But now you close Kitematic and later start it again. In this case you will miss the list of created containers, plus opening the 'Settings' > 'Volumes' will not show any entries at all.

A workaround would be to click the 'SAVE' button and then open another tab and come back to the 'Volumes' tab.

The 'empty' folder entry cannot have its local folder modified until you've clicked the

I will check that.

Perhaps the Local 'Change' button should auto-fill the Docker Folder input if one hasn't been defined (last folder in the path?)

This is a good idea. It could be done now or later.

Contributor

zedtux commented Jul 2, 2015

Initial load of the 'Volumes' tab did not show the Dockerfile exposed volumes

This is a bug in Kitematic. I have already noticed it but didn't fixed it.
Let say it's the first time you run Kitematic, all is fine. You create container(s) and work with. You will not have this issue.
But now you close Kitematic and later start it again. In this case you will miss the list of created containers, plus opening the 'Settings' > 'Volumes' will not show any entries at all.

A workaround would be to click the 'SAVE' button and then open another tab and come back to the 'Volumes' tab.

The 'empty' folder entry cannot have its local folder modified until you've clicked the

I will check that.

Perhaps the Local 'Change' button should auto-fill the Docker Folder input if one hasn't been defined (last folder in the path?)

This is a good idea. It could be done now or later.

@TeckniX

This comment has been minimized.

Show comment
Hide comment
@TeckniX

TeckniX Jul 2, 2015

Contributor

Thanks for the replies - Regarding the following:

  • Initial load of the 'Volumes' tab did not show the Dockerfile exposed volumes
    Works consistently for me and always displays the proper Dockerfile volume on 0.7.4 - Perhaps you just need to merge your code with the latest from origin/master?
Contributor

TeckniX commented Jul 2, 2015

Thanks for the replies - Regarding the following:

  • Initial load of the 'Volumes' tab did not show the Dockerfile exposed volumes
    Works consistently for me and always displays the proper Dockerfile volume on 0.7.4 - Perhaps you just need to merge your code with the latest from origin/master?
@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jul 3, 2015

Contributor

@TeckniX you was right ! Merging master solved this issue 👍

Contributor

zedtux commented Jul 3, 2015

@TeckniX you was right ! Merging master solved this issue 👍

@TeckniX

This comment has been minimized.

Show comment
Hide comment
@TeckniX

TeckniX Jul 8, 2015

Contributor

@zedtux Where you able to change the functionality when the 'empty' folder is being displayed?

Contributor

TeckniX commented Jul 8, 2015

@zedtux Where you able to change the functionality when the 'empty' folder is being displayed?

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Jul 8, 2015

Contributor

Sorry not yet ... I'm finishing my move ... :)

Contributor

zedtux commented Jul 8, 2015

Sorry not yet ... I'm finishing my move ... :)

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Oct 21, 2015

Contributor

@zedtux Would you mind bringing this branch up to date with master so that I can do some QA and hopefully see it merged?

Contributor

FrenchBen commented Oct 21, 2015

@zedtux Would you mind bringing this branch up to date with master so that I can do some QA and hopefully see it merged?

@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Oct 22, 2015

Contributor

@FrenchBen I prefer to wait for the Linux support branch is merged first as I need it in order to update this branch.

Contributor

zedtux commented Oct 22, 2015

@FrenchBen I prefer to wait for the Linux support branch is merged first as I need it in order to update this branch.

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Oct 22, 2015

Contributor

More than fine by me! Let me know when you get some progress updating the latest Linux branch.

Contributor

FrenchBen commented Oct 22, 2015

More than fine by me! Let me know when you get some progress updating the latest Linux branch.

@FrenchBen FrenchBen referenced this pull request Oct 26, 2015

Closed

Add volume from OSX #1139

@iteman iteman referenced this pull request in phpmentors-jp/docker-images Nov 17, 2015

Closed

Support volumes through Kitematic #8

@FrenchBen

This comment has been minimized.

Show comment
Hide comment
@FrenchBen

FrenchBen Jan 18, 2016

Contributor

Closing this one in favor of: #1202

Contributor

FrenchBen commented Jan 18, 2016

Closing this one in favor of: #1202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment