New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple kitematic cfg support for VM #992

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@FrenchBen
Contributor

FrenchBen commented Aug 28, 2015

This is a quick mod to allow 'advance' users to point Kitematic to their VM and if the VM doesn't exist, create it with the optional memory size.

Filename and location: ~/.kitematicfg

Expected format:

{
    "virtualbox": {
        "name": "default",
        "memory": "2048"
    }
}

Signed-off-by: FrenchBen <me(at)frenchben.com>

Simple kitematic cfg support for VM
Signed-off-by: FrenchBen <me@frenchben.com>
@FrenchBen

This comment has been minimized.

Contributor

FrenchBen commented Sep 3, 2015

@mchiang0610 @jeffdm Could you QA this change and see if it's applicable to the project?

Thanks!

@jmorganca

This comment has been minimized.

Contributor

jmorganca commented Oct 5, 2015

@FrenchBen sorry for the delay. Thanks for the PR! My initial feeling is that we shouldn't introduce a new config file. Most users will probably create their VM before seeing this feature - meaning they need to delete their VM and re-create it for this to work.

@FrenchBen

This comment has been minimized.

Contributor

FrenchBen commented Oct 5, 2015

agreed - I did make some changes to it to be more of a VM selector in another PR

@FrenchBen FrenchBen closed this Oct 5, 2015

@bwidmeier

This comment has been minimized.

bwidmeier commented Nov 24, 2015

I would just like to voice my support for this feature. I agree that it has limited discoverability, and even that users may discover it after beginning to build out their 'default' machine, but given that this is more targeted at advanced users anyways, I'm not sure that that matters too much. If a user wants to go through that process, why stop them?

I should note that actually integrating multi machine support into the UI would be a better option, but this config file option seems easy to do and helpful in the meantime.

@FrenchBen

This comment has been minimized.

Contributor

FrenchBen commented Nov 24, 2015

@bwidmeier I'm working on adding proper machine support into the UI, which prevents the need for this conf file :)

@bwidmeier

This comment has been minimized.

bwidmeier commented Nov 24, 2015

@FrenchBen Thanks a lot! Is there an issue that I could subscribe to?

@FrenchBen

This comment has been minimized.

Contributor

FrenchBen commented Nov 24, 2015

@bwidmeier Checkout #1061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment