New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New msgpack implementation #79
Conversation
👍 and congrats on the new msgpack impl! IMHO, that should live in its own repo, it is worth using independently of libchan. |
@mcollina I will likely split it out later, I wanted it at least reviewed as a whole first since the libchan changes are in lockstep. |
05c0561
to
84f8d20
Compare
This is now a working implementation with full unit test passing. Still going to increase coverage for the new library and updated implementation. |
84f8d20
to
ec20b10
Compare
Pushed an update with the msgpack changes split out. I submitted upstream but until then my fork will need to be used (https://github.com/dmcgowan/msgpack/tree/raw-message), use the raw-message branch until I get it onto master. |
ec20b10
to
889aa5b
Compare
The msgpack fork has been cleaned up and this PR is ready to merge. Any additional changes and refactoring to libchan should be done on top of this change. Ping @stevvooe @BrianBland for a chance to review |
fb87bc4
to
e59e5ce
Compare
Also removed dead code related to registering and encoding raw connections. This is unused and unspecified. Rather than porting the logic, much of the code was commented out. Now it is completely removed. |
Closing to see if reopen will enable circlci |
- Reintroduce SendTo and ReceiveFrom - Use raw message when receiving from spdy - Zero copy in-mem transport - Remove raw connection encoding Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Update Send and Receive objects to lock access and save their encoder/decoder. Additionally use a buffered writer on encode. Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
e59e5ce
to
a44d6a0
Compare
Re-creating PR for new CI integration and code review |
I mark this as a work in progress since it is not ready to be merged. The code design may be reviewed since I plan on using this structure.
Includes:
What this enables: