New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker deamon doesn't work with --fixed-cidr on windows #1916

Merged
merged 1 commit into from Dec 8, 2017

Conversation

Projects
None yet
3 participants
@msabansal
Contributor

msabansal commented Aug 18, 2017

Docker deamon fails to start when launched with --fixed-cidr parameter on windows.

This is because we are sending an invalid gateway address. Sending a gateway address was a temporary workaround which was added to prevent the daemon from crashing and is not needed any more so removing that.

@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Aug 18, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fixcidr" git@github.com:msabansal/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Aug 18, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fixcidr" git@github.com:msabansal/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@GordonTheTurtle GordonTheTurtle added dco/no and removed dco/no labels Aug 18, 2017

Docker deamon doesn't work with --fixed-cidr on windows
Signed-off-by: Sandeep Bansal <sabansal@microsoft.com>

@fcrisciani fcrisciani self-requested a review Aug 18, 2017

@msabansal

This comment has been minimized.

Show comment
Hide comment
@msabansal
Contributor

msabansal commented Dec 8, 2017

@fcrisciani fcrisciani merged commit 822e5b5 into docker:master Dec 8, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
dco-signed All commits are signed

fcrisciani added a commit to fcrisciani/docker that referenced this pull request Dec 14, 2017

Libnetwork vendoring
Windows fixes:
docker/libnetwork#1916
docker/libnetwork#2014
docker/libnetwork#2021

Fix for veth leak on daemon crash
Cleanup networkDB logic for node management

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>

@fcrisciani fcrisciani referenced this pull request Dec 14, 2017

Closed

Libnetwork vendoring #35792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment