New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hostname lookup on chain exists check #1974

Merged
merged 1 commit into from Oct 7, 2017

Conversation

Projects
None yet
4 participants
@cpuguy83
Contributor

cpuguy83 commented Oct 7, 2017

Without -n, iptables will attempt to lookup hostnames for IP
addresses, which can slow down the call dramatically.
Since we don't need this, and generally don't even care about the
output, use the -n flag to disable this.

Signed-off-by: Brian Goff cpuguy83@gmail.com

Disable hostname lookup on chain exists check
Without `-n`, iptables will attempt to lookup hostnames for IP
addresses, which can slow down the call dramatically.
Since we don't need this, and generally don't even care about the
output, use the `-n` flag to disable this.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

@fcrisciani fcrisciani self-requested a review Oct 7, 2017

@fcrisciani

This comment has been minimized.

Show comment
Hide comment
@fcrisciani

fcrisciani Oct 7, 2017

Member

LGTM

Member

fcrisciani commented Oct 7, 2017

LGTM

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 7, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@17ca8a6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1974   +/-   ##
=========================================
  Coverage          ?   38.49%           
=========================================
  Files             ?      137           
  Lines             ?    27351           
  Branches          ?        0           
=========================================
  Hits              ?    10530           
  Misses            ?    15524           
  Partials          ?     1297
Impacted Files Coverage Δ
iptables/iptables.go 54.57% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ca8a6...8dce207. Read the comment docs.

codecov-io commented Oct 7, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@17ca8a6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1974   +/-   ##
=========================================
  Coverage          ?   38.49%           
=========================================
  Files             ?      137           
  Lines             ?    27351           
  Branches          ?        0           
=========================================
  Hits              ?    10530           
  Misses            ?    15524           
  Partials          ?     1297
Impacted Files Coverage Δ
iptables/iptables.go 54.57% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ca8a6...8dce207. Read the comment docs.

@mavenugo mavenugo merged commit 6c51292 into docker:master Oct 7, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
dco-signed All commits are signed
@fcrisciani

This comment has been minimized.

Show comment
Hide comment
@fcrisciani

fcrisciani Oct 7, 2017

Member

@mavenugo can you add some label so that we don't miss the backport?

Member

fcrisciani commented Oct 7, 2017

@mavenugo can you add some label so that we don't miss the backport?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment