Fix ndots configuration #1995
Merged
Fix ndots configuration #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ndots was being explicitely passed in the daemon conf the configuration landing into the container was corrupted e.g. options ndots:1 ndots:0 The fix just removes the user option so that is not replicated Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #1995 +/- ##
=========================================
Coverage ? 38.09%
=========================================
Files ? 137
Lines ? 27365
Branches ? 0
=========================================
Hits ? 10426
Misses ? 15664
Partials ? 1275
Continue to review full report at Codecov.
|
Validate that passing an option into the daemon config does not corrupt the option set into the container resolv.conf Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ndots was being explicitely passed in the daemon conf
the configuration landing into the container was corrupted
e.g. options ndots:1 ndots:0
The fix just removes the user option so that is not replicated
FIXES: #1988
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com