New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Disable hostname lookup on chain exists check #2019

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@thaJeztah
Member

thaJeztah commented Nov 20, 2017

cherry-pick of #1974 for 17.09

git checkout -b 17.09-backport-iptables_no_dns_lookup upstream/bump_17.09
git cherry-pick -s -S -x 8dce207dddc3f805b852088a60cc27bfe54b065e

Without -n, iptables will attempt to lookup hostnames for IP
addresses, which can slow down the call dramatically.
Since we don't need this, and generally don't even care about the
output, use the -n flag to disable this.

(cherry picked from commit 8dce207)

@cpuguy83

LGTM

Disable hostname lookup on chain exists check
Without `-n`, iptables will attempt to lookup hostnames for IP
addresses, which can slow down the call dramatically.
Since we don't need this, and generally don't even care about the
output, use the `-n` flag to disable this.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 8dce207)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@fcrisciani

This comment has been minimized.

Show comment
Hide comment
@fcrisciani

fcrisciani Nov 20, 2017

Member

LGTM

Member

fcrisciani commented Nov 20, 2017

LGTM

@fcrisciani fcrisciani merged commit ca1f761 into docker:bump_17.09 Nov 20, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
dco-signed All commits are signed

@thaJeztah thaJeztah deleted the thaJeztah:17.09-backport-iptables_no_dns_lookup branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment