New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix lint issues #2020

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
2 participants
@thaJeztah
Member

thaJeztah commented Nov 20, 2017

cherry-pick of #1947 for the 17.09 branch

git checkout -b 17.09-backport-fix-lint upstream/bump_17.09
git cherry-pick -s -S -x 9e5748ad7dc65318889693365a53492be94b1521

The package updated and now shows new warnings that had to be corrected to let the CI pass

Fix lint issues
The package updated and now shows new warnings that had to be corrected
to let the CI pass

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
(cherry picked from commit 9e5748a)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Nov 20, 2017

Member

ping @fcrisciani this is likely needed for all cherry-picks in this branch to go green 😅

Member

thaJeztah commented Nov 20, 2017

ping @fcrisciani this is likely needed for all cherry-picks in this branch to go green 😅

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Nov 20, 2017

Member

I'll rebase the other PR's after this one has been merged 👍

Member

thaJeztah commented Nov 20, 2017

I'll rebase the other PR's after this one has been merged 👍

@fcrisciani

This comment has been minimized.

Show comment
Hide comment
@fcrisciani

fcrisciani Nov 20, 2017

Member

LGTM

Member

fcrisciani commented Nov 20, 2017

LGTM

@fcrisciani fcrisciani merged commit 0039095 into docker:bump_17.09 Nov 20, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
dco-signed All commits are signed

@thaJeztah thaJeztah deleted the thaJeztah:17.09-backport-fix-lint branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment