New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup node management logic #2036

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
3 participants
@fcrisciani
Member

fcrisciani commented Dec 13, 2017

Created method to handle the node state change with cleanup operation
associated.
Realign testing client with the new diagnostic interface

Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com
(cherry picked from commit b499aa9)

Cleanup node management logic
Created method to handle the node state change with cleanup operation
associated.
Realign testing client with the new diagnostic interface

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
(cherry picked from commit b499aa9)
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 13, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (bump_17.12@9bca9a4). Click here to learn what that means.
The diff coverage is 81.7%.

Impacted file tree graph

@@              Coverage Diff              @@
##             bump_17.12    #2036   +/-   ##
=============================================
  Coverage              ?   40.18%           
=============================================
  Files                 ?      138           
  Lines                 ?    22135           
  Branches              ?        0           
=============================================
  Hits                  ?     8895           
  Misses                ?    11935           
  Partials              ?     1305
Impacted Files Coverage Δ
networkdb/networkdbdiagnose.go 0% <0%> (ø)
networkdb/event_delegate.go 68.57% <50%> (ø)
networkdb/delegate.go 75% <73.33%> (ø)
networkdb/nodemgmt.go 92.59% <92.59%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bca9a4...38f98b1. Read the comment docs.

codecov-io commented Dec 13, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (bump_17.12@9bca9a4). Click here to learn what that means.
The diff coverage is 81.7%.

Impacted file tree graph

@@              Coverage Diff              @@
##             bump_17.12    #2036   +/-   ##
=============================================
  Coverage              ?   40.18%           
=============================================
  Files                 ?      138           
  Lines                 ?    22135           
  Branches              ?        0           
=============================================
  Hits                  ?     8895           
  Misses                ?    11935           
  Partials              ?     1305
Impacted Files Coverage Δ
networkdb/networkdbdiagnose.go 0% <0%> (ø)
networkdb/event_delegate.go 68.57% <50%> (ø)
networkdb/delegate.go 75% <73.33%> (ø)
networkdb/nodemgmt.go 92.59% <92.59%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bca9a4...38f98b1. Read the comment docs.

@mavenugo mavenugo merged commit 7dd202d into docker:bump_17.12 Dec 13, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
dco-signed All commits are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment