New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass network name to drivers as an option #514

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dcbw

dcbw commented Sep 10, 2015

No description provided.

@dcbw

This comment has been minimized.

Show comment
Hide comment
@dcbw

dcbw Sep 10, 2015

@mavenugo @thockin @mrjana See #486 (comment) for more details. This is more of a straw-man PR to see what the best approach is. Should it get passed as an option for backwards compatibility, or should we change the CreateNetwork() arguments to include the network name?

dcbw commented Sep 10, 2015

@mavenugo @thockin @mrjana See #486 (comment) for more details. This is more of a straw-man PR to see what the best approach is. Should it get passed as an option for backwards compatibility, or should we change the CreateNetwork() arguments to include the network name?

@mavenugo

This comment has been minimized.

Show comment
Hide comment
@mavenugo

mavenugo Sep 10, 2015

Contributor

@dcbw thanks for the patch. But sorry this is a dupe of #139
please review the discussion and you will understand the reasoning behind not accepting this patch.
Will close this PR.

Contributor

mavenugo commented Sep 10, 2015

@dcbw thanks for the patch. But sorry this is a dupe of #139
please review the discussion and you will understand the reasoning behind not accepting this patch.
Will close this PR.

@mavenugo mavenugo closed this Sep 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment