New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad order of iptables filter rules #961

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Projects
None yet
5 participants
@JrCs
Contributor

JrCs commented Feb 21, 2016

Rules with ctstate RELATED,ESTABLISHED must be create before same rules without ctstate.

See moby/moby#18911

@mavenugo

This comment has been minimized.

Show comment
Hide comment
@mavenugo

mavenugo Mar 17, 2016

Contributor

@aboch can you PTAL

Contributor

mavenugo commented Mar 17, 2016

@aboch can you PTAL

@aboch

This comment has been minimized.

Show comment
Hide comment
@aboch

aboch Apr 12, 2016

Contributor

I cannot get all the integ tests pass with this change.
@JrCs can you take a look:

sudo make clean integration-tests

(make sure to also patch 389d498)

Contributor

aboch commented Apr 12, 2016

I cannot get all the integ tests pass with this change.
@JrCs can you take a look:

sudo make clean integration-tests

(make sure to also patch 389d498)

Fix bad order of iptables filter rules
Rules with ctstate RELATED,ESTABLISHED must be create before same
rules without ctstate.

Signed-off-by: Yves Blusseau <90z7oey02@sneakemail.com>
@JrCs

This comment has been minimized.

Show comment
Hide comment
@JrCs

JrCs Apr 17, 2016

Contributor

I have rebase my PR.
All tests are now successful.

Contributor

JrCs commented Apr 17, 2016

I have rebase my PR.
All tests are now successful.

@aboch

This comment has been minimized.

Show comment
Hide comment
@aboch

aboch Apr 20, 2016

Contributor

LGTM

Contributor

aboch commented Apr 20, 2016

LGTM

@JrCs

This comment has been minimized.

Show comment
Hide comment
@JrCs

JrCs Jun 28, 2016

Contributor

Do you think it will be merge soon ?

Contributor

JrCs commented Jun 28, 2016

Do you think it will be merge soon ?

@sanimej

This comment has been minimized.

Show comment
Hide comment
@sanimej

sanimej Mar 6, 2017

Contributor

@JrCs Thanks and sorry about the really long delay. LGTM.

Contributor

sanimej commented Mar 6, 2017

@JrCs Thanks and sorry about the really long delay. LGTM.

@sanimej sanimej merged commit 1dbfb17 into docker:master Mar 6, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
docker/dco-signed All commits signed
Details

@aboch aboch referenced this pull request Mar 14, 2017

Merged

bump 17.04.0-rc1 #31811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment