Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to node 16 #158

Merged
merged 1 commit into from Feb 28, 2022
Merged

update to node 16 #158

merged 1 commit into from Feb 28, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 28, 2022

@crazy-max crazy-max force-pushed the node-16 branch 2 times, most recently from 27013a6 to 832a805 Compare Feb 28, 2022
@crazy-max
Copy link
Member Author

crazy-max commented Feb 28, 2022

@svasek While upgrading to node 16 I encountered an issue with the proxy-agent package. I switched to another one. Can you try with uses: crazy-max/docker-login-action@node-16 and let me know if it still works? Thx.

@svasek
Copy link

svasek commented Feb 28, 2022

@svasek While upgrading to node 16 I encountered an issue with the proxy-agent package. I switched to another one. Can you try with uses: crazy-max/docker-login-action@node-16 and let me know if it still works? Thx.

Hi @crazy-max,
Unfortunately it doesn't work:

Run github-test/docker-login-action@node-16
::save-state name=isPost::true
##[debug]Save intra-action state isPost = true
::save-state name=registry::***.dkr.ecr.us-west-2.amazonaws.com
##[debug]Save intra-action state registry = ***.dkr.ecr.us-west-2.amazonaws.com
::save-state name=logout::true
##[debug]Save intra-action state logout = true
Retrieving registries data through AWS SDK...
##[debug]Requesting AWS ECR auth token for ***
##[debug]Using http proxy http://proxy-us-aws.xxx.yyy:3128/
Error: A "socks" protocol must be specified! Got: http:
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Login to AWS ECR

@crazy-max
Copy link
Member Author

crazy-max commented Feb 28, 2022

@svasek Thanks for your feedback! That's what I thought. I will take a look and keep you in touch.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

crazy-max commented Feb 28, 2022

@svasek Can you try again? Thx!

@svasek
Copy link

svasek commented Feb 28, 2022

Hi @crazy-max,
Looks good now:

Run github-test/docker-login-action@node-16
::save-state name=isPost::true
##[debug]Save intra-action state isPost = true
::save-state name=registry::***.dkr.ecr.us-west-2.amazonaws.com
##[debug]Save intra-action state registry = ***.dkr.ecr.us-west-2.amazonaws.com
::save-state name=logout::true
##[debug]Save intra-action state logout = true
Retrieving registries data through AWS SDK...
##[debug]Requesting AWS ECR auth token for ***
##[debug]Using http proxy http://proxy-us-aws.xxx.yyy:3128/
##[debug]Using https proxy http://proxy-us-aws.xxx.yyy:3128/
AWS ECR detected with us-west-2 region
Logging into https://***.dkr.ecr.us-west-2.amazonaws.com...
Login Succeeded!
##[debug]Node Action run completed with exit code 0
##[debug]Finishing: Login to AWS ECR

Thank you,
Milos

@crazy-max
Copy link
Member Author

crazy-max commented Feb 28, 2022

Thanks again!

@crazy-max crazy-max merged commit 4e3c937 into docker:master Feb 28, 2022
2 checks passed
@crazy-max crazy-max deleted the node-16 branch Feb 28, 2022
@jguillon
Copy link

jguillon commented Feb 28, 2022

Hi!
I ran into the following error message using act to run it locally:

Error: The runs.using key in action.yml must be one of: [composite docker node12], got node16

I guess it's related to this PR, but do I have to change something on my side?

Thanks for your help,
Jeremy

@crazy-max
Copy link
Member Author

crazy-max commented Feb 28, 2022

@jguillon This is not officially supported by GitHub. Suggest to open an issue on the act repo: https://github.com/nektos/act/search?q=node16&type=issues

@jguillon
Copy link

jguillon commented Feb 28, 2022

Noted. For those who need to bypass the issue; simply uses: docker/login-action@v1.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants