Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test login against ACR #49

Merged
merged 1 commit into from Jan 27, 2022
Merged

Test login against ACR #49

merged 1 commit into from Jan 27, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Dec 22, 2020

Ref. #23

Now against:

  • Azure Container Registry
    • AZURE_REGISTRY_NAME
    • AZURE_CLIENT_ID
    • AZURE_CLIENT_SECRET

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from chris-crone Dec 22, 2020
@crazy-max crazy-max marked this pull request as ready for review Jan 27, 2022
@crazy-max
Copy link
Member Author

@crazy-max crazy-max commented Jan 27, 2022

Secrets has been created for ACR (cc @RomainBelorgey).

Tested on my fork:

image

PTAL @chris-crone

@crazy-max crazy-max requested a review from tonistiigi Jan 27, 2022
@crazy-max crazy-max merged commit 7948fff into docker:master Jan 27, 2022
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant