Rename "none" driver to "test" #2437
Conversation
I would add that everything that targets an existing host is done with the |
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
915a30d
to
9a2332a
This is ready for review. ping @docker/machine-maintainers |
LGTM |
We don't want to push this without you taking a glance @nathanleclaire . But this would help for the release since it ends the 'none' driver misunderstanding. |
Isn't the It would be good to add this support to some other driver before removing what little support exists. |
Yes, @jeanlaurent Can we please open a thread and discuss what's to be done about the My feeling is that the communication with the community and existing users of the |
Note that Docker's existing feature deprecation policy indicates that such an action (deprecating |
@nathanleclaire I'm wondering when |
@dgageot My understanding is that it worked prior to 0.5.0. #2270 has some more context. Even if it never worked, I would personally rather see the feature fixed than removed, per @dnephin's comment:
|
@dgageot |
Closing will, re-open if needed by #2667 |
Following @ehazlett advice here this PR rename the none driver to test, and remove it from the release package, set the
generic
driver as default driver and remove the documentation related to it. We keep using it to run the various integration test, where it is of great help in allowing a faster execution time.The driver
none
in it's current state is not usable. The hardcoded ssh user is a blank string the ssh port is 0, and those can not be overriden.The main purpose of this driver,or at least how it was partially documented to, is to register an existing running docker instance, which is what the
generic
driver do.This will close #2270, #2355, #1532, #1435 and #643