New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine host-only interface dynamically, stop assuming eth1 #3112

Merged
merged 1 commit into from Feb 26, 2016

Conversation

Projects
None yet
4 participants
@thieman
Copy link
Contributor

thieman commented Feb 24, 2016

Fixes #3108.

@thieman thieman force-pushed the thieman:tnt-host-only-ip branch from 2c9d127 to f9bb5eb Feb 24, 2016

@nathanleclaire

This comment has been minimized.

Copy link
Contributor

nathanleclaire commented Feb 24, 2016

Cool! Want to take a whack at some unit tests?

@thieman

This comment has been minimized.

Copy link
Contributor

thieman commented Feb 24, 2016

Sure, I'll see if I can base anything off what's already there.

Determine host-only interface dynamically, stop assuming eth1
Signed-off-by: Travis Thieman <travis.thieman@gmail.com>

@thieman thieman force-pushed the thieman:tnt-host-only-ip branch from f9bb5eb to b57c4c2 Feb 25, 2016

@thieman

This comment has been minimized.

Copy link
Contributor

thieman commented Feb 25, 2016

@nathanleclaire Added unit tests for the two new methods I added, thanks!

@nathanleclaire

This comment has been minimized.

Copy link
Contributor

nathanleclaire commented Feb 25, 2016

Awesome! Will take this for a spin today.

@nathanleclaire

This comment has been minimized.

Copy link
Contributor

nathanleclaire commented Feb 26, 2016

LGTM

nathanleclaire added a commit that referenced this pull request Feb 26, 2016

Merge pull request #3112 from thieman/tnt-host-only-ip
Determine host-only interface dynamically, stop assuming eth1

@nathanleclaire nathanleclaire merged commit aab4190 into docker:master Feb 26, 2016

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 30.684%
Details
docker/dco-signed All commits signed
Details
documentation success 1 tests run, 1 skipped, 0 failed.
Details
@nathanleclaire

This comment has been minimized.

Copy link
Contributor

nathanleclaire commented Feb 26, 2016

Considering doing a patch release (Machine 0.6.1) for this. @dgageot @jeanlaurent WDYT

@dgageot

This comment has been minimized.

Copy link
Contributor

dgageot commented Feb 26, 2016

@nathanleclaire

This comment has been minimized.

Copy link
Contributor

nathanleclaire commented Feb 26, 2016

I'll do some integration testing etc. and think about cutting a patch release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment