New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for eventual consistency on AWS spot instances #4312

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@nolith
Contributor

nolith commented Nov 16, 2017

Also requesting a spot instance is subject to eventual consistency, this patch implements a retry method around spot instance waiter.

It fixes #3539

Wait for eventual consistency on AWS spot instances
Also requesting a spot instance is subject to eventual consistency,
this patch implements a retry method around spot instance waiter.

Signed-off-by: Alessio Caiazza <acaiazza@gitlab.com>
@dgageot

This comment has been minimized.

Show comment
Hide comment
@dgageot

dgageot Nov 17, 2017

Collaborator

LGTM

Collaborator

dgageot commented Nov 17, 2017

LGTM

@dgageot dgageot merged commit 49dfaa7 into docker:master Nov 23, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dco-signed All commits are signed

@nolith nolith deleted the nolith:3539-retry-on-spot-instances branch Nov 23, 2017

@nolith

This comment has been minimized.

Show comment
Hide comment
@nolith

nolith Nov 23, 2017

Contributor

Thanks @dgageot
Can I ask about docker-machine release cycle?
How often is a release made out of master?

Contributor

nolith commented Nov 23, 2017

Thanks @dgageot
Can I ask about docker-machine release cycle?
How often is a release made out of master?

@shin- shin- added this to the 0.14.0 milestone Feb 26, 2018

Vad1mo added a commit to Vad1mo/terraform-aws-gitlab-runner that referenced this pull request May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment