New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #4591

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@mgrachev
Contributor

mgrachev commented Oct 14, 2018

No description provided.

@GordonTheTurtle

This comment has been minimized.

GordonTheTurtle commented Oct 14, 2018

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:mgrachev/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Fix typo
Signed-off-by: Mikhail Grachev <work@mgrachev.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Oct 18, 2018

@shin-

This comment has been minimized.

Member

shin- commented Oct 31, 2018

Thanks!

@shin- shin- merged commit 15cde71 into docker:master Oct 31, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
dco-signed All commits are signed

@mgrachev mgrachev deleted the mgrachev:patch-1 branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment