Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert changes to set associated head sha on pull request event #239

Merged
merged 1 commit into from Oct 17, 2022

Conversation

crazy-max
Copy link
Member

fixes #238
follow-up #234 (comment)

cc @gustavovalverde @ianschmitz

revert changes to set associated head sha on pull request event and use commit sha that triggered the workflow by default. User can still set associated head sha on PR by setting the env var DOCKER_METADATA_PR_HEAD_SHA=true.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from jedevc Oct 17, 2022
jedevc
jedevc approved these changes Oct 17, 2022
@crazy-max crazy-max requested review from tonistiigi and jedevc Oct 17, 2022
@gustavovalverde
Copy link

Thank you for understanding the impact and reverting it this soon. Kudos 👍🏻

@tonistiigi tonistiigi merged commit d00b20e into docker:master Oct 17, 2022
22 checks passed
@crazy-max crazy-max deleted the github-sha branch Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR #234 was a breaking change
4 participants