Conversation
371b508 to
ab73612
Compare
tonistiigi
reviewed
Sep 2, 2021
README.md
Outdated
Member
There was a problem hiding this comment.
https://github.com/tonistiigi/binfmt/blob/master/.github/buildkit.toml is a somewhat nice pattern as well. Maybe we should show it as well.
Member
There was a problem hiding this comment.
Actually, I thought that sometimes I would prefer putting a file under .github to trying to inline toml inside yaml. Maybe intro "providing a toml configuration with a file or inline block" and leave one example to use one and second another syntax.
3d860f2 to
3624e14
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3624e14 to
34e94a5
Compare
tonistiigi
approved these changes
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow inline config for BuildKit in the workflow. Could be useful to load a config dynamically:
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com