Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip setting buildkitd flags and config for remote driver #161

Merged
merged 1 commit into from Sep 16, 2022

Conversation

crazy-max
Copy link
Member

buildkitd-flags is not supported by the remote driver.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@@ -63,7 +63,7 @@ async function run(): Promise<void> {
await context.asyncForEach(inputs.driverOpts, async driverOpt => {
createArgs.push('--driver-opt', driverOpt);
});
if (inputs.buildkitdFlags) {
if (inputs.driver != 'remote' && inputs.buildkitdFlags) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the same logic below for config as well I think - see driver/remote/factory.go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not done it for config because it doesn't have a default value like buildkitdFlags but maybe we should just skip for it too I'm not sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok actually will be confusing if we do for one but not the other. Should be good now.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title skip setting buildkitd flags for remote driver skip setting buildkitd flags and config for remote driver Sep 16, 2022
jedevc
jedevc approved these changes Sep 16, 2022
@crazy-max crazy-max merged commit f385c9e into docker:master Sep 16, 2022
30 checks passed
@crazy-max crazy-max deleted the fix-remote branch September 16, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants