Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve quotes surrounding fields in input list #174

Merged
merged 1 commit into from Oct 18, 2022

Conversation

crazy-max
Copy link
Member

fixes #173

In the toolkit api, args passed to exec are not quoted correctly: https://github.com/actions/toolkit/blob/9b58167dc9923ca0399b2451f4b3b2c6d4f25f3b/packages/exec/src/toolrunner.ts#L71-L77 as they are using child_process.spawn().

With Node.js spawn, double-quotes take precedence over single-quotes, so the spawn call breaks down. Looks like this has been solved when using a windows runner but not on linux.

To mitigate this issue we need to preserve quotes surrounding fields in input list.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as draft October 17, 2022 20:27
@crazy-max crazy-max marked this pull request as ready for review October 18, 2022 08:24
@crazy-max crazy-max requested a review from jedevc October 18, 2022 08:28
jedevc
jedevc approved these changes Oct 18, 2022
@crazy-max crazy-max merged commit 693fdd6 into docker:master Oct 18, 2022
32 checks passed
@crazy-max crazy-max deleted the input-quote branch October 18, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.2.0 ignores quotation marks in input parameter "driver-opts"
2 participants