Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ws from 7.3.1 to 7.5.0 #90

merged 1 commit into from Jun 23, 2021


Copy link

@dependabot dependabot bot commented Jun 23, 2021

Bumps ws from 7.3.1 to 7.5.0.

Release notes

Sourced from ws's releases.



  • Some errors now have a code property describing the specific type of error that has occurred (#1901).

Bug fixes

  • A close frame is now sent to the remote peer if an error (such as a data framing error) occurs (8806aa9a).
  • The close code is now always 1006 if no close frame is received, even if the connection is closed due to an error (8806aa9a).


Bug fixes

  • Fixed a ReDoS vulnerability (00c425ec).

A specially crafted value of the Sec-Websocket-Protocol header could be used to significantly slow down a ws server.

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();
value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start);

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.


Bug fixes

  • UTF-8 validation is now done even if utf-8-validate is not installed (23ba6b29).
  • Fixed an edge case where websocket.close() and websocket.terminate() did not close the connection (67e25ff5).


... (truncated)

  • e3f0c17 [dist] 7.5.0
  • 1d3f4cb [doc] Fix anchor tags for error codes
  • 6eea0d4 [doc] Fix typo
  • bb5d44b [doc] Sort error codes alphabetically
  • c6e3080 [minor] Attach error codes to all receiver errors (#1901)
  • 074e6a8 [fix] Don't call ws.terminate() unconditionally in duplex._destroy()
  • 8806aa9 [fix] Close the connection cleanly when an error occurs
  • 05b8ccd [doc] Fix broken link (#1897)
  • 03a7078 [doc] Remove unsafe regex from code snippet
  • 7ee3115 [doc] Add logo to coverage badge
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ws]( from 7.3.1 to 7.5.0.
- [Release notes](
- [Commits](websockets/ws@7.3.1...7.5.0)

- dependency-name: ws
  dependency-type: indirect

Signed-off-by: dependabot[bot] <>
Copy link

@codecov-commenter codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #90 (1dd5af0) into master (b1f1f71) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
  Coverage   70.83%   70.83%           
  Files           5        5           
  Lines         144      144           
  Branches       24       24           
  Hits          102      102           
  Misses         30       30           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f1f71...1dd5af0. Read the comment docs.

@crazy-max crazy-max merged commit 1806a02 into master Jun 23, 2021
22 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ws-7.5.0 branch Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants